Re: [Mesa-dev] [PATCH 1/6] mesa: add MaxNumLevels to gl_texture_image, remove MaxLog2

2012-11-12 Thread Brian Paul
On 11/11/2012 09:39 AM, Marek Olšák wrote: MaxLog2 led to bugs, because it didn't work well with 1D and 3D textures. NOTE: This is a candidate for the stable branches. --- src/mesa/drivers/dri/nouveau/nouveau_texture.c |2 +- src/mesa/drivers/dri/radeon/radeon_mipmap_tree.c |6 ++--

Re: [Mesa-dev] [PATCH 1/6] mesa: add MaxNumLevels to gl_texture_image, remove MaxLog2

2012-11-11 Thread Marek Olšák
AFAIK, r600g has been immune to some of these bugs. You can set last_level to any large value and it will just work. Christoph B. told me he had had a problem with last_level being too large and I decided to review all the other related places in mesa/main and st/mesa and came up with this series j

Re: [Mesa-dev] [PATCH 1/6] mesa: add MaxNumLevels to gl_texture_image, remove MaxLog2

2012-11-11 Thread Dave Airlie
> MaxLog2 led to bugs, because it didn't work well with 1D and 3D textures. They all look good to me, but I suppose Brian might want to check them over, Any ideas for a piglit test to show any of this or is it mostly just internal bugs at the driver interfaces? Reviewed-by: Dave Airlie Dave. __

[Mesa-dev] [PATCH 1/6] mesa: add MaxNumLevels to gl_texture_image, remove MaxLog2

2012-11-11 Thread Marek Olšák
MaxLog2 led to bugs, because it didn't work well with 1D and 3D textures. NOTE: This is a candidate for the stable branches. --- src/mesa/drivers/dri/nouveau/nouveau_texture.c |2 +- src/mesa/drivers/dri/radeon/radeon_mipmap_tree.c |6 ++-- src/mesa/main/mtypes.h