Re: [Mesa-dev] [PATCH 1/6] i965: Split Gen4-5 and Gen6+ MATH instruction emitters.

2014-06-08 Thread Jordan Justen
Series Reviewed-by: Jordan Justen On Sat, Jun 7, 2014 at 11:47 AM, Kenneth Graunke wrote: > Our existing functions, brw_math and brw_math2, had unclear roles: > > Gen4-5 used brw_math for both unary and binary math functions; it never > used brw_math2. Since operands are already in message regi

Re: [Mesa-dev] [PATCH 1/6] i965: Split Gen4-5 and Gen6+ MATH instruction emitters.

2014-06-08 Thread Matt Turner
This series is Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/6] i965: Split Gen4-5 and Gen6+ MATH instruction emitters.

2014-06-07 Thread Kenneth Graunke
Our existing functions, brw_math and brw_math2, had unclear roles: Gen4-5 used brw_math for both unary and binary math functions; it never used brw_math2. Since operands are already in message registers, this is reasonable. Gen6+ used brw_math for unary math functions, and brw_math2 for binary m