Re: [Mesa-dev] [PATCH 1/6] glsl: Switch opcode and avail parameters to binop().

2015-12-03 Thread Matt Turner
On Thu, Dec 3, 2015 at 4:24 PM, Matt Turner wrote: > On Thu, Dec 3, 2015 at 4:22 PM, Eric Anholt wrote: >> Matt Turner writes: >> >>> To make it match unop(). >> >> FWIW, this series plus the algebraic patch appears to net the same code >> generated on vc4, so I'm fine with it. Based on the oth

Re: [Mesa-dev] [PATCH 1/6] glsl: Switch opcode and avail parameters to binop().

2015-12-03 Thread Matt Turner
On Thu, Dec 3, 2015 at 4:22 PM, Eric Anholt wrote: > Matt Turner writes: > >> To make it match unop(). > > FWIW, this series plus the algebraic patch appears to net the same code > generated on vc4, so I'm fine with it. Based on the other feedback, it > does seem like we should leave the GLSL op

Re: [Mesa-dev] [PATCH 1/6] glsl: Switch opcode and avail parameters to binop().

2015-12-03 Thread Eric Anholt
Matt Turner writes: > To make it match unop(). FWIW, this series plus the algebraic patch appears to net the same code generated on vc4, so I'm fine with it. Based on the other feedback, it does seem like we should leave the GLSL ops for now and just change the NIR to be simpler. signature.as

Re: [Mesa-dev] [PATCH 1/6] glsl: Switch opcode and avail parameters to binop().

2015-12-01 Thread Ian Romanick
The series is Reviewed-by: Ian Romanick Patch 1 could probably land right away, but the others should probably wait until Ilia relaxes his objection. I'd really like to have Ken or Jason also review patch 6. On 11/30/2015 03:32 PM, Matt Turner wrote: > To make it match unop(). > --- > src/gls

[Mesa-dev] [PATCH 1/6] glsl: Switch opcode and avail parameters to binop().

2015-11-30 Thread Matt Turner
To make it match unop(). --- src/glsl/builtin_functions.cpp | 35 ++- 1 file changed, 18 insertions(+), 17 deletions(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index c5489b7..88f9a71 100644 --- a/src/glsl/builtin_functions.cpp +