Re: [Mesa-dev] [PATCH 1/6] glsl: Prehash in refcount hash table to reduce hashing

2017-05-22 Thread Thomas Helland
2017-05-22 21:44 GMT+02:00 Thomas Helland : > 2017-05-22 21:19 GMT+02:00 Ian Romanick : >> On 05/22/2017 11:55 AM, Thomas Helland wrote: >>> _mesa_hash_table_search is one of our hottest function according to perf. >>> Callgrind shows the refcounting as one of the major users of the >>> searching f

Re: [Mesa-dev] [PATCH 1/6] glsl: Prehash in refcount hash table to reduce hashing

2017-05-22 Thread Thomas Helland
2017-05-22 21:19 GMT+02:00 Ian Romanick : > On 05/22/2017 11:55 AM, Thomas Helland wrote: >> _mesa_hash_table_search is one of our hottest function according to perf. >> Callgrind shows the refcounting as one of the major users of the >> searching functions. We can reduce the pain by prehashing, so

Re: [Mesa-dev] [PATCH 1/6] glsl: Prehash in refcount hash table to reduce hashing

2017-05-22 Thread Ian Romanick
On 05/22/2017 11:55 AM, Thomas Helland wrote: > _mesa_hash_table_search is one of our hottest function according to perf. > Callgrind shows the refcounting as one of the major users of the > searching functions. We can reduce the pain by prehashing, so that we > avoid hashing two times when inserti

[Mesa-dev] [PATCH 1/6] glsl: Prehash in refcount hash table to reduce hashing

2017-05-22 Thread Thomas Helland
_mesa_hash_table_search is one of our hottest function according to perf. Callgrind shows the refcounting as one of the major users of the searching functions. We can reduce the pain by prehashing, so that we avoid hashing two times when inserting in the table. On a short shader-db run (with valid