Re: [Mesa-dev] [PATCH 1/6] gallium: clarify the constraints on sampler_view_destroy

2017-10-11 Thread Nicolai Hähnle
On 11.10.2017 01:25, Gurchetan Singh wrote: "The GL state tracker, which is the only one that runs into the multi-context subtleties (due to share groups), already guarantees that sampler views are destroyed before their context of creation is destroyed." How does the GL state tracker guarante

Re: [Mesa-dev] [PATCH 1/6] gallium: clarify the constraints on sampler_view_destroy

2017-10-10 Thread Gurchetan Singh
"The GL state tracker, which is the only one that runs into the multi-context subtleties (due to share groups), already guarantees that sampler views are destroyed before their context of creation is destroyed." How does the GL state tracker guarantee this? Does this guarantee also apply to pipe_

Re: [Mesa-dev] [PATCH 1/6] gallium: clarify the constraints on sampler_view_destroy

2017-10-10 Thread Nicolai Hähnle
Same as on IRC: On 10.10.2017 04:06, Marek Olšák wrote: Is there any difference with piglit/drawoverhead? Yes, there is. If yes, would this be useful? https://patchwork.freedesktop.org/patch/41241/ Surprisingly, not that much. I'm going to think though a couple of other options, but want

Re: [Mesa-dev] [PATCH 1/6] gallium: clarify the constraints on sampler_view_destroy

2017-10-09 Thread Marek Olšák
Hi Nicolai, Is there any difference with piglit/drawoverhead? If yes, would this be useful? https://patchwork.freedesktop.org/patch/41241/ Marek On Fri, Oct 6, 2017 at 10:38 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > r600 expects the context that created the sampler view to still

Re: [Mesa-dev] [PATCH 1/6] gallium: clarify the constraints on sampler_view_destroy

2017-10-06 Thread Nicolai Hähnle
FWIW, the drivers that really are affected currently are SVGA and possibly virgl, because they pass Gallium calls on to a supervisor. Since we guarantee that the creation context is still alive, those drivers could fix any issues by adding samplers that are destroyed from a different context to

[Mesa-dev] [PATCH 1/6] gallium: clarify the constraints on sampler_view_destroy

2017-10-06 Thread Nicolai Hähnle
From: Nicolai Hähnle r600 expects the context that created the sampler view to still be alive (there is a per-context list of sampler views). svga currently bails when the context of destruction is not the same as creation. The GL state tracker, which is the only one that runs into the multi-c