Re: [Mesa-dev] [PATCH 1/6] anv: hook internal validate layer only for debug builds

2016-07-27 Thread Jason Ekstrand
I looked at the one validate function we still have and I don't think it validates anything that won't trigger asserts elsewhere. Let's just kill it all. On Jul 27, 2016 8:37 AM, "Emil Velikov" wrote: > On 27 July 2016 at 16:17, Jason Ekstrand wrote: > > On Jul 27, 2016 6:03 AM, "Emil Velikov"

Re: [Mesa-dev] [PATCH 1/6] anv: hook internal validate layer only for debug builds

2016-07-27 Thread Emil Velikov
On 27 July 2016 at 16:17, Jason Ekstrand wrote: > On Jul 27, 2016 6:03 AM, "Emil Velikov" wrote: >> >> From: Emil Velikov >> >> Presently the layer has only a single entry point, which uses asserts >> solely. >> Thus even on release builds the function (and thus the whole layer) will >> do >> no

Re: [Mesa-dev] [PATCH 1/6] anv: hook internal validate layer only for debug builds

2016-07-27 Thread Jason Ekstrand
On Jul 27, 2016 6:03 AM, "Emil Velikov" wrote: > > From: Emil Velikov > > Presently the layer has only a single entry point, which uses asserts solely. > Thus even on release builds the function (and thus the whole layer) will do > nothing but adding runtime and binary(size) overhead. > > Cc: "12

[Mesa-dev] [PATCH 1/6] anv: hook internal validate layer only for debug builds

2016-07-27 Thread Emil Velikov
From: Emil Velikov Presently the layer has only a single entry point, which uses asserts solely. Thus even on release builds the function (and thus the whole layer) will do nothing but adding runtime and binary(size) overhead. Cc: "12.0" Cc: Jason Ekstrand Signed-off-by: Emil Velikov --- We c