Re: [Mesa-dev] [PATCH 1/5] nir: Don't insert a fake link if unnecessary.

2015-09-10 Thread Connor Abbott
On Wed, Sep 9, 2015 at 1:37 AM, Kenneth Graunke wrote: > On Saturday, September 05, 2015 11:10:58 AM Connor Abbott wrote: >> On Sat, Sep 5, 2015 at 2:31 AM, Kenneth Graunke >> wrote: >> > On Friday, September 04, 2015 11:56:29 AM Connor Abbott wrote: >> >> I'm confused as to how this can happen.

Re: [Mesa-dev] [PATCH 1/5] nir: Don't insert a fake link if unnecessary.

2015-09-08 Thread Kenneth Graunke
On Saturday, September 05, 2015 11:10:58 AM Connor Abbott wrote: > On Sat, Sep 5, 2015 at 2:31 AM, Kenneth Graunke wrote: > > On Friday, September 04, 2015 11:56:29 AM Connor Abbott wrote: > >> I'm confused as to how this can happen. The fake link is only for the > >> situation where we have an in

Re: [Mesa-dev] [PATCH 1/5] nir: Don't insert a fake link if unnecessary.

2015-09-05 Thread Connor Abbott
On Sat, Sep 5, 2015 at 2:31 AM, Kenneth Graunke wrote: > On Friday, September 04, 2015 11:56:29 AM Connor Abbott wrote: >> On Thu, Sep 3, 2015 at 2:32 PM, Kenneth Graunke >> wrote: >> > Prevents regressions in ~128 tests when fixing unlink_block_successors >> > in the next commit. >> > >> > XXX:

Re: [Mesa-dev] [PATCH 1/5] nir: Don't insert a fake link if unnecessary.

2015-09-04 Thread Kenneth Graunke
On Friday, September 04, 2015 11:56:29 AM Connor Abbott wrote: > On Thu, Sep 3, 2015 at 2:32 PM, Kenneth Graunke wrote: > > Prevents regressions in ~128 tests when fixing unlink_block_successors > > in the next commit. > > > > XXX: Zero thought has been put into whether this is the right solution

Re: [Mesa-dev] [PATCH 1/5] nir: Don't insert a fake link if unnecessary.

2015-09-04 Thread Connor Abbott
On Thu, Sep 3, 2015 at 2:32 PM, Kenneth Graunke wrote: > Prevents regressions in ~128 tests when fixing unlink_block_successors > in the next commit. > > XXX: Zero thought has been put into whether this is the right solution I'm confused as to how this can happen. The fake link is only for the si

[Mesa-dev] [PATCH 1/5] nir: Don't insert a fake link if unnecessary.

2015-09-03 Thread Kenneth Graunke
Prevents regressions in ~128 tests when fixing unlink_block_successors in the next commit. XXX: Zero thought has been put into whether this is the right solution Signed-off-by: Kenneth Graunke --- src/glsl/nir/nir_control_flow.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) The