Re: [Mesa-dev] [PATCH 1/5] mesa: align atomic buffer handling code with ubo/ssbo

2017-09-15 Thread Iago Toral
Thanks for cleaning this up, I left some minor comments in this patch but otherwise patches 1-4 are: Reviewed-by: Iago Toral Quiroga Regarding patch 5, I have not worked on the state tracker before, but the change seems straight forward enough that I think you can also add my Rb (it is the same

Re: [Mesa-dev] [PATCH 1/5] mesa: align atomic buffer handling code with ubo/ssbo

2017-09-15 Thread Iago Toral
On Fri, 2017-09-15 at 13:57 +1000, Dave Airlie wrote: > From: Dave Airlie > > this adds automatic size support to the atomic buffer code, > but also realigns the code to act like the ubo/ssbo code. > > Signed-off-by: Dave Airlie > --- >  src/mesa/main/bufferobj.c | 132 +

Re: [Mesa-dev] [PATCH 1/5] mesa: align atomic buffer handling code with ubo/ssbo

2017-09-15 Thread Samuel Pitoiset
On 09/15/2017 05:57 AM, Dave Airlie wrote: From: Dave Airlie this adds automatic size support to the atomic buffer code, but also realigns the code to act like the ubo/ssbo code. Signed-off-by: Dave Airlie --- src/mesa/main/bufferobj.c | 132 ++

[Mesa-dev] [PATCH 1/5] mesa: align atomic buffer handling code with ubo/ssbo

2017-09-14 Thread Dave Airlie
From: Dave Airlie this adds automatic size support to the atomic buffer code, but also realigns the code to act like the ubo/ssbo code. Signed-off-by: Dave Airlie --- src/mesa/main/bufferobj.c | 132 ++ src/mesa/main/mtypes.h| 1 + 2 files chan