Re: [Mesa-dev] [PATCH 1/5] mesa: add support for ARB_sample_locations

2018-05-08 Thread Marek Olšák
On Fri, May 4, 2018 at 8:09 AM, Rhys Perry wrote: > Signed-off-by: Rhys Perry > --- > src/mapi/glapi/gen/gl_API.xml | 52 +++ > src/mesa/main/config.h | 7 + > src/mesa/main/dd.h | 7 + > src/mesa/main/extensions_table.h| 1 + >

Re: [Mesa-dev] [PATCH 1/5] mesa: add support for ARB_sample_locations

2018-05-07 Thread Brian Paul
A bunch of nit-picks below. On 05/04/2018 06:09 AM, Rhys Perry wrote: Signed-off-by: Rhys Perry --- src/mapi/glapi/gen/gl_API.xml | 52 +++ src/mesa/main/config.h | 7 + src/mesa/main/dd.h | 7 + src/mesa/main/extensions_table.h

Re: [Mesa-dev] [PATCH 1/5] mesa: add support for ARB_sample_locations

2018-05-04 Thread Ian Romanick
A bunch of comments below. This is probably the only patch in the series that I'm going to review. On 05/04/2018 05:09 AM, Rhys Perry wrote: > Signed-off-by: Rhys Perry > --- > src/mapi/glapi/gen/gl_API.xml | 52 +++ > src/mesa/main/config.h | 7 + > src/mesa/m

[Mesa-dev] [PATCH 1/5] mesa: add support for ARB_sample_locations

2018-05-04 Thread Rhys Perry
Signed-off-by: Rhys Perry --- src/mapi/glapi/gen/gl_API.xml | 52 +++ src/mesa/main/config.h | 7 + src/mesa/main/dd.h | 7 + src/mesa/main/extensions_table.h| 1 + src/mesa/main/fbobject.c| 247 +++