Re: [Mesa-dev] [PATCH 1/5] intel: Add a macro for printing a debug warning once.

2012-10-16 Thread Eric Anholt
Jason Wood writes: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 10/15/2012 10:41 AM, Eric Anholt wrote: >> Jason Wood writes: >> >>> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >>> >>> On 10/12/2012 04:30 PM, Eric Anholt wrote: There are a number of places where some obscure

Re: [Mesa-dev] [PATCH 1/5] intel: Add a macro for printing a debug warning once.

2012-10-15 Thread Jason Wood
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/15/2012 03:50 PM, Chad Versace wrote: >> On a side note, the "do { ... } while(0)" portion of the code >> looks funny to me, and I have to assume that it is some oddball >> compiler workaround. GCC works just fine when this code is >> wrapped in

Re: [Mesa-dev] [PATCH 1/5] intel: Add a macro for printing a debug warning once.

2012-10-15 Thread Jason Wood
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/15/2012 10:41 AM, Eric Anholt wrote: > Jason Wood writes: > >> -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> >> On 10/12/2012 04:30 PM, Eric Anholt wrote: >>> There are a number of places where some obscure piece of the >>> code is not curr

Re: [Mesa-dev] [PATCH 1/5] intel: Add a macro for printing a debug warning once.

2012-10-15 Thread Matt Turner
On Mon, Oct 15, 2012 at 8:41 AM, Jason Wood wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 10/12/2012 04:30 PM, Eric Anholt wrote: >> There are a number of places where some obscure piece of the code >> is not currently worth fixing, and we have some workaround behavior >> availab

Re: [Mesa-dev] [PATCH 1/5] intel: Add a macro for printing a debug warning once.

2012-10-15 Thread Eric Anholt
Jason Wood writes: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 10/12/2012 04:30 PM, Eric Anholt wrote: >> There are a number of places where some obscure piece of the code >> is not currently worth fixing, and we have some workaround behavior >> available. It's nicer for users to do

Re: [Mesa-dev] [PATCH 1/5] intel: Add a macro for printing a debug warning once.

2012-10-15 Thread Jason Wood
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 10/12/2012 04:30 PM, Eric Anholt wrote: > There are a number of places where some obscure piece of the code > is not currently worth fixing, and we have some workaround behavior > available. It's nicer for users to do some lame workaround than to >

[Mesa-dev] [PATCH 1/5] intel: Add a macro for printing a debug warning once.

2012-10-12 Thread Eric Anholt
There are a number of places where some obscure piece of the code is not currently worth fixing, and we have some workaround behavior available. It's nicer for users to do some lame workaround than to just assert, but without asserts we never knew when the workaround was at fault. This should giv