Re: [Mesa-dev] [PATCH 1/5] i965: wrap assert param in #ifndef NDEBUG

2016-10-04 Thread Iago Toral
On Tue, 2016-10-04 at 22:38 +1100, Timothy Arceri wrote: > On Tue, 2016-10-04 at 10:33 +0200, Iago Toral wrote: > > > > The series is: > > > > Reviewed-by: Iago Toral Quiroga > Thanks for taking a look. Are you happy with me changing patch 1 and > 4 > to use MAYBE_UNUSED as suggested by Gražvyda

Re: [Mesa-dev] [PATCH 1/5] i965: wrap assert param in #ifndef NDEBUG

2016-10-04 Thread Timothy Arceri
On Tue, 2016-10-04 at 10:33 +0200, Iago Toral wrote: > The series is: > > Reviewed-by: Iago Toral Quiroga Thanks for taking a look. Are you happy with me changing patch 1 and 4 to use MAYBE_UNUSED as suggested by Gražvydas? > > On Tue, 2016-10-04 at 11:15 +1100, Timothy Arceri wrote: > > > >

Re: [Mesa-dev] [PATCH 1/5] i965: wrap assert param in #ifndef NDEBUG

2016-10-04 Thread Grazvydas Ignotas
On Tue, Oct 4, 2016 at 3:15 AM, Timothy Arceri wrote: > This fixes an unused variable warning on release builds. > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp > b/src/mesa/drivers/dri/i965/brw_fs.cpp

Re: [Mesa-dev] [PATCH 1/5] i965: wrap assert param in #ifndef NDEBUG

2016-10-04 Thread Iago Toral
The series is: Reviewed-by: Iago Toral Quiroga On Tue, 2016-10-04 at 11:15 +1100, Timothy Arceri wrote: > This fixes an unused variable warning on release builds. > --- >  src/mesa/drivers/dri/i965/brw_fs.cpp | 4 >  1 file changed, 4 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 1/5] i965: wrap assert param in #ifndef NDEBUG

2016-10-03 Thread Timothy Arceri
This fixes an unused variable warning on release builds. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index dc000d9..ccf311d 100644 --- a/src/mesa/drivers/dri/i965/brw_f