Re: [Mesa-dev] [PATCH 1/5] glsl: Allow vector logic ops to be generated.

2015-03-23 Thread Matt Turner
On Wed, Mar 18, 2015 at 6:30 PM, Connor Abbott wrote: > So in GLSL, add and mul can take a combination of a scalar and a > vector, and it'll splat the scalar automatically, and with this this > series that means that and/or can now take a combination of a scalar > and a vector as well, and we'll h

Re: [Mesa-dev] [PATCH 1/5] glsl: Allow vector logic ops to be generated.

2015-03-18 Thread Connor Abbott
So in GLSL, add and mul can take a combination of a scalar and a vector, and it'll splat the scalar automatically, and with this this series that means that and/or can now take a combination of a scalar and a vector as well, and we'll have to splat them as well. Are you sure that the various backen

Re: [Mesa-dev] [PATCH 1/5] glsl: Allow vector logic ops to be generated.

2015-03-18 Thread Ian Romanick
Patches 1, 2, and 3 are Reviewed-by: Ian Romanick Patches 4 and 5 are Acked-by: Ian Romanick On 03/18/2015 11:37 AM, Matt Turner wrote: > They're not accessible from the source language, but optimizations are > allowed to generate them. > --- > src/glsl/ir_validate.cpp

[Mesa-dev] [PATCH 1/5] glsl: Allow vector logic ops to be generated.

2015-03-18 Thread Matt Turner
They're not accessible from the source language, but optimizations are allowed to generate them. --- src/glsl/ir_validate.cpp | 6 +++--- src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp | 9 +++-- 2 files changed, 6 insertions(+), 9 deletions(-) diff -