Re: [Mesa-dev] [PATCH 1/5] draw: make sure clipdistances work with geometry shaders

2013-06-11 Thread Zack Rusin
> > + unsigned clipdistance_output[2]; > > Why 2? Are there four clip distances per register, and we need 8 (or > 6?) of them? Maybe add some comments. Hmm, I thought we already had a documentation for it. It's the same code that we already have in the vertex shader, just extending it to geo

Re: [Mesa-dev] [PATCH 1/5] draw: make sure clipdistances work with geometry shaders

2013-06-11 Thread Brian Paul
On 06/10/2013 08:31 AM, Zack Rusin wrote: we were always fetching the info from the vertex shader, but if geometry shader is present it should be used as the source of that info. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/draw/draw_cliptest_tmp.h |3 ++- src/gallium/auxiliary/dr

[Mesa-dev] [PATCH 1/5] draw: make sure clipdistances work with geometry shaders

2013-06-10 Thread Zack Rusin
we were always fetching the info from the vertex shader, but if geometry shader is present it should be used as the source of that info. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/draw/draw_cliptest_tmp.h |3 ++- src/gallium/auxiliary/draw/draw_context.c | 11 +++ src