Re: [Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-08-01 Thread Jason Ekstrand
On Fri, Aug 1, 2014 at 2:56 AM, Juha-Pekka Heikkila < juhapekka.heikk...@gmail.com> wrote: > On 01.08.2014 06:39, Jason Ekstrand wrote: > > This adds the API entrypoint, error checking logic, and a driver hook for > > the ARB_copy_image extension. > > > > v2: Fix a typo in ARB_copy_image.xml and a

Re: [Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-08-01 Thread Neil Roberts
There is one line that is 116 characters long (!) but apart from that: Reviewed-by: Neil Roberts Regards, - Neil ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-08-01 Thread Juha-Pekka Heikkila
On 01.08.2014 06:39, Jason Ekstrand wrote: > This adds the API entrypoint, error checking logic, and a driver hook for > the ARB_copy_image extension. > > v2: Fix a typo in ARB_copy_image.xml and add it to the makefile > v3: Put ARB_copy_image.xml in the right place alphebetically in the makefile

[Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-07-31 Thread Jason Ekstrand
This adds the API entrypoint, error checking logic, and a driver hook for the ARB_copy_image extension. v2: Fix a typo in ARB_copy_image.xml and add it to the makefile v3: Put ARB_copy_image.xml in the right place alphebetically in the makefile and update the commit message Signed-off-by: Jason

Re: [Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-07-31 Thread Marek Olšák
Hi Jason, The prefix of the commit message should be "mesa: ", because it modifies mesa/main. Marek On Fri, Aug 1, 2014 at 1:47 AM, Jason Ekstrand wrote: > This adds the API entrypoint, error checking logic, and a driver hook for > the ARB_copy_image extension. > > v2: Fix a typo in ARB_copy_im

Re: [Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-07-31 Thread Matt Turner
On Thu, Jul 31, 2014 at 4:47 PM, Jason Ekstrand wrote: > diff --git a/src/mapi/glapi/gen/Makefile.am b/src/mapi/glapi/gen/Makefile.am > index 212731f..f0bf34a 100644 > --- a/src/mapi/glapi/gen/Makefile.am > +++ b/src/mapi/glapi/gen/Makefile.am > @@ -114,6 +114,7 @@ API_XML = \ > ARB_clear_

[Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-07-31 Thread Jason Ekstrand
This adds the API entrypoint, error checking logic, and a driver hook for the ARB_copy_image extension. v2: Fix a typo in ARB_copy_image.xml and add it to the makefile Signed-off-by: Jason Ekstrand --- src/mapi/glapi/gen/ARB_copy_image.xml | 28 +++ src/mapi/glapi/gen/Makefile.am| 1

Re: [Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-07-31 Thread Jason Ekstrand
On Thu, Jul 31, 2014 at 11:38 AM, Ilia Mirkin wrote: > On Thu, Jul 31, 2014 at 2:27 PM, Jason Ekstrand > wrote: > > This adds the API entrypoint, error checking logic, and a driver hook for > > the ARB_copy_image extension. > > > > Signed-off-by: Jason Ekstrand > > --- > > src/mapi/glapi/gen/A

Re: [Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-07-31 Thread Ilia Mirkin
On Thu, Jul 31, 2014 at 2:27 PM, Jason Ekstrand wrote: > This adds the API entrypoint, error checking logic, and a driver hook for > the ARB_copy_image extension. > > Signed-off-by: Jason Ekstrand > --- > src/mapi/glapi/gen/ARB_copy_image.xml | 28 +++ > src/mapi/glapi/gen/gl_API.xml |

[Mesa-dev] [PATCH 1/5] Add GL API support for ARB_copy_image

2014-07-31 Thread Jason Ekstrand
This adds the API entrypoint, error checking logic, and a driver hook for the ARB_copy_image extension. Signed-off-by: Jason Ekstrand --- src/mapi/glapi/gen/ARB_copy_image.xml | 28 +++ src/mapi/glapi/gen/gl_API.xml | 2 +- src/mapi/glapi/gen/gl_genexec.py | 1 + src/mesa/Makef