Re: [Mesa-dev] [PATCH 1/4] util: Add a drm_find_modifier helper

2019-03-14 Thread Eric Anholt
Alyssa Rosenzweig writes: > This function is replicated across vc4/v3d/freedreno and is needed in > Panfrost; let's make this shared code. > > Signed-off-by: Alyssa Rosenzweig > --- > src/util/u_drm.h | 46 ++ > 1 file changed, 46 insertions(+) > cre

Re: [Mesa-dev] [PATCH 1/4] util: Add a drm_find_modifier helper

2019-03-14 Thread Alyssa Rosenzweig
> hmm, I guess there are already two or three other places that already > copy/pasta'd this specifically for modifiers.. so I'm ok with the less > generic name, since it (IMHO) makes the code calling it more clear. This was my reasoning, yeah... I'm not sure why it is so generic, honestly (should

Re: [Mesa-dev] [PATCH 1/4] util: Add a drm_find_modifier helper

2019-03-14 Thread Rob Clark
On Thu, Mar 14, 2019 at 5:51 AM Eric Engestrom wrote: > > On Thursday, 2019-03-14 04:19:02 +, Alyssa Rosenzweig wrote: > > This function is replicated across vc4/v3d/freedreno and is needed in > > Panfrost; let's make this shared code. > > > > Signed-off-by: Alyssa Rosenzweig > > --- > > src

Re: [Mesa-dev] [PATCH 1/4] util: Add a drm_find_modifier helper

2019-03-14 Thread Eric Engestrom
On Thursday, 2019-03-14 04:19:02 +, Alyssa Rosenzweig wrote: > This function is replicated across vc4/v3d/freedreno and is needed in > Panfrost; let's make this shared code. > > Signed-off-by: Alyssa Rosenzweig > --- > src/util/u_drm.h | 46 ++ > 1

Re: [Mesa-dev] [PATCH 1/4] util: Add a drm_find_modifier helper

2019-03-14 Thread Christian Gmeiner
Am Do., 14. März 2019 um 05:19 Uhr schrieb Alyssa Rosenzweig : > > This function is replicated across vc4/v3d/freedreno and is needed in > Panfrost; let's make this shared code. > > Signed-off-by: Alyssa Rosenzweig > --- > src/util/u_drm.h | 46 ++ > 1

[Mesa-dev] [PATCH 1/4] util: Add a drm_find_modifier helper

2019-03-13 Thread Alyssa Rosenzweig
This function is replicated across vc4/v3d/freedreno and is needed in Panfrost; let's make this shared code. Signed-off-by: Alyssa Rosenzweig --- src/util/u_drm.h | 46 ++ 1 file changed, 46 insertions(+) create mode 100644 src/util/u_drm.h diff --gi