Re: [Mesa-dev] [PATCH 1/4] nir: Avoid C99 field initializers.

On Thu, Apr 28, 2016 at 11:55 AM, Jose Fonseca wrote: > On 28/04/16 18:43, Jason Ekstrand wrote: > >> On Thu, Apr 28, 2016 at 8:49 AM, Jose Fonseca > > wrote: >> >> On 28/04/16 15:37, Connor Abbott wrote: >> >> For the series: >> >> Reviewed-by: Con

Re: [Mesa-dev] [PATCH 1/4] nir: Avoid C99 field initializers.

On 28/04/16 18:43, Jason Ekstrand wrote: On Thu, Apr 28, 2016 at 8:49 AM, Jose Fonseca mailto:jfons...@vmware.com>> wrote: On 28/04/16 15:37, Connor Abbott wrote: For the series: Reviewed-by: Connor Abbott mailto:cwabbo...@gmail.com>> For the zero-sized array thing

Re: [Mesa-dev] [PATCH 1/4] nir: Avoid C99 field initializers.

On Thu, Apr 28, 2016 at 8:49 AM, Jose Fonseca wrote: > On 28/04/16 15:37, Connor Abbott wrote: > >> For the series: >> >> Reviewed-by: Connor Abbott >> >> For the zero-sized array thing... we could make it a statically-sized >> array, since we never have more than 4 arguments to an ALU >> instru

Re: [Mesa-dev] [PATCH 1/4] nir: Avoid C99 field initializers.

On 28/04/16 15:37, Connor Abbott wrote: For the series: Reviewed-by: Connor Abbott For the zero-sized array thing... we could make it a statically-sized array, since we never have more than 4 arguments to an ALU instruction, but that would be wasteful of memory. Also, we always have at least 1

Re: [Mesa-dev] [PATCH 1/4] nir: Avoid C99 field initializers.

For the series: Reviewed-by: Connor Abbott For the zero-sized array thing... we could make it a statically-sized array, since we never have more than 4 arguments to an ALU instruction, but that would be wasteful of memory. Also, we always have at least 1 argument, so we could make the size 1 to

Re: [Mesa-dev] [PATCH 1/4] nir: Avoid C99 field initializers.

Maybe add a short commit message for 3/4 Reviewed-by: Sinclair Yeh On Thu, Apr 28, 2016 at 12:27:05PM +0100, Jose Fonseca wrote: > As they are not standard C++ and are not supported by MSVC C++ compiler. > > Just have nir_imm_double match nir_imm_float above. > --- > src/compiler/nir/nir_build

[Mesa-dev] [PATCH 1/4] nir: Avoid C99 field initializers.

As they are not standard C++ and are not supported by MSVC C++ compiler. Just have nir_imm_double match nir_imm_float above. --- src/compiler/nir/nir_builder.h | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/compiler/nir/nir_builder.h b/src/compiler/nir/nir_builde