Re: [Mesa-dev] [PATCH 1/4] mesa: move declarations before code

2013-06-30 Thread Jose Fonseca
- Original Message - > Brian Paul writes: > > > On 06/26/2013 04:33 PM, Eric Anholt wrote: > >> Brian Paul writes: > >> > >>> On 06/26/2013 03:56 PM, Ian Romanick wrote: > Patches 1 and 4 are > > Reviewed-by: Ian Romanick > > For patch 3, I share Jose's concer

Re: [Mesa-dev] [PATCH 1/4] mesa: move declarations before code

2013-06-27 Thread Eric Anholt
Brian Paul writes: > On 06/26/2013 04:33 PM, Eric Anholt wrote: >> Brian Paul writes: >> >>> On 06/26/2013 03:56 PM, Ian Romanick wrote: Patches 1 and 4 are Reviewed-by: Ian Romanick For patch 3, I share Jose's concern. I would very much like to see this happen in

Re: [Mesa-dev] [PATCH 1/4] mesa: move declarations before code

2013-06-27 Thread Jose Fonseca
- Original Message - > On 06/26/2013 04:33 PM, Eric Anholt wrote: > > Brian Paul writes: > > > >> On 06/26/2013 03:56 PM, Ian Romanick wrote: > >>> Patches 1 and 4 are > >>> > >>> Reviewed-by: Ian Romanick > >>> > >>> For patch 3, I share Jose's concern. I would very much like to see t

Re: [Mesa-dev] [PATCH 1/4] mesa: move declarations before code

2013-06-26 Thread Brian Paul
On 06/26/2013 04:33 PM, Eric Anholt wrote: Brian Paul writes: On 06/26/2013 03:56 PM, Ian Romanick wrote: Patches 1 and 4 are Reviewed-by: Ian Romanick For patch 3, I share Jose's concern. I would very much like to see this happen in directories containing code that will be built with MSV

Re: [Mesa-dev] [PATCH 1/4] mesa: move declarations before code

2013-06-26 Thread Eric Anholt
Brian Paul writes: > On 06/26/2013 03:56 PM, Ian Romanick wrote: >> Patches 1 and 4 are >> >> Reviewed-by: Ian Romanick >> >> For patch 3, I share Jose's concern. I would very much like to see this >> happen in directories containing code that will be built with MSVC. > > Yeah, sounds good, but

Re: [Mesa-dev] [PATCH 1/4] mesa: move declarations before code

2013-06-26 Thread Brian Paul
On 06/26/2013 03:56 PM, Ian Romanick wrote: Patches 1 and 4 are Reviewed-by: Ian Romanick For patch 3, I share Jose's concern. I would very much like to see this happen in directories containing code that will be built with MSVC. Yeah, sounds good, but off-hand I have no idea how to do this

Re: [Mesa-dev] [PATCH 1/4] mesa: move declarations before code

2013-06-26 Thread Ian Romanick
Patches 1 and 4 are Reviewed-by: Ian Romanick For patch 3, I share Jose's concern. I would very much like to see this happen in directories containing code that will be built with MSVC. For patch 2, I think this is unnecessary if patch 3 is re-done. Right? On 06/26/2013 12:50 PM, Brian Pa

[Mesa-dev] [PATCH 1/4] mesa: move declarations before code

2013-06-26 Thread Brian Paul
--- src/mesa/program/register_allocate.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/program/register_allocate.c b/src/mesa/program/register_allocate.c index ea06a07..4eed0b5 100644 --- a/src/mesa/program/register_allocate.c +++ b/src/mesa/program/register