Re: [Mesa-dev] [PATCH 1/4] mesa: implement GL_ARB_draw_indirect

2013-04-05 Thread Christoph Bumiller
On 05.04.2013 13:32, Christoph Bumiller wrote: > On 04.04.2013 21:17, Brian Paul wrote: >> I just did a quick skim and found a few minor things. >> >> First, the subject might be "mesa: implement GL_ARB_draw_indirect and >> GL_ARB_multi_draw_indirect" >> >> This is a big patch and I think it could

Re: [Mesa-dev] [PATCH 1/4] mesa: implement GL_ARB_draw_indirect

2013-04-05 Thread Christoph Bumiller
On 04.04.2013 21:17, Brian Paul wrote: > I just did a quick skim and found a few minor things. > > First, the subject might be "mesa: implement GL_ARB_draw_indirect and > GL_ARB_multi_draw_indirect" > > This is a big patch and I think it could have been broken down into > smaller pieces, but I know

Re: [Mesa-dev] [PATCH 1/4] mesa: implement GL_ARB_draw_indirect

2013-04-04 Thread Brian Paul
I just did a quick skim and found a few minor things. First, the subject might be "mesa: implement GL_ARB_draw_indirect and GL_ARB_multi_draw_indirect" This is a big patch and I think it could have been broken down into smaller pieces, but I know it's a PITA to redo. Next time. On 04/04/2

[Mesa-dev] [PATCH 1/4] mesa: implement GL_ARB_draw_indirect

2013-04-04 Thread Christoph Bumiller
--- src/mapi/glapi/gen/Makefile.am |1 + src/mapi/glapi/gen/gl_API.xml|4 +- src/mesa/drivers/dri/i965/brw_draw.c |3 +- src/mesa/drivers/dri/i965/brw_draw.h |3 +- src/mesa/drivers/dri/nouveau/nouveau_vbo_t.c |9 +- src/mesa/main/a

Re: [Mesa-dev] [PATCH 1/4] mesa: implement GL_ARB_draw_indirect

2013-02-02 Thread Christoph Bumiller
On 02.02.2013 08:32, Adrian M Negreanu wrote: > On Fri, Feb 1, 2013 at 11:50 PM, Christoph Bumiller > wrote: >> I have 1 piglit test to check drawing with several combinations of >> parameters (using transform feedback to write the commands), but >> will make some more tests for various things lik

Re: [Mesa-dev] [PATCH 1/4] mesa: implement GL_ARB_draw_indirect

2013-02-01 Thread Adrian M Negreanu
On Fri, Feb 1, 2013 at 11:50 PM, Christoph Bumiller wrote: > I have 1 piglit test to check drawing with several combinations of > parameters (using transform feedback to write the commands), but > will make some more tests for various things like interaction with > PrimitiveRestart or error condit

[Mesa-dev] [PATCH 1/4] mesa: implement GL_ARB_draw_indirect

2013-02-01 Thread Christoph Bumiller
I have 1 piglit test to check drawing with several combinations of parameters (using transform feedback to write the commands), but will make some more tests for various things like interaction with PrimitiveRestart or error conditions. (http://people.freedesktop.org/~chrisbmr/0001-arb_draw_indire