Re: [Mesa-dev] [PATCH 1/4] mesa: add MAX_PIXEL_BYTES define

2011-12-06 Thread Eric Anholt
On Mon, 5 Dec 2011 20:43:14 -0700, Brian Paul wrote: > In a few places we need to allocate space for some number of generic > pixels. Use this new define instead of a magic number like 16 or > 4 * sizeof(GLuint). Just one comment to patch 4/4, other than that, the series is: Reviewed-by: Eric

Re: [Mesa-dev] [PATCH 1/4] mesa: add MAX_PIXEL_BYTES define

2011-12-06 Thread Brian Paul
On 12/06/2011 02:10 AM, Jose Fonseca wrote: I suppose that 16 is enough because Mesa always uses floats as intermediates (and never doubles), right? Correct. Either way is a good cleanup. -Brian ___ mesa-dev mailing list mesa-dev@lists.freedeskt

Re: [Mesa-dev] [PATCH 1/4] mesa: add MAX_PIXEL_BYTES define

2011-12-06 Thread Jose Fonseca
And the rest of the series looks good to me too. Jose - Original Message - > I suppose that 16 is enough because Mesa always uses floats as > intermediates (and never doubles), right? > > Either way is a good cleanup. > > Jose > > - Original Message - > > In a few places we nee

Re: [Mesa-dev] [PATCH 1/4] mesa: add MAX_PIXEL_BYTES define

2011-12-06 Thread Jose Fonseca
I suppose that 16 is enough because Mesa always uses floats as intermediates (and never doubles), right? Either way is a good cleanup. Jose - Original Message - > In a few places we need to allocate space for some number of generic > pixels. Use this new define instead of a magic numbe

[Mesa-dev] [PATCH 1/4] mesa: add MAX_PIXEL_BYTES define

2011-12-05 Thread Brian Paul
In a few places we need to allocate space for some number of generic pixels. Use this new define instead of a magic number like 16 or 4 * sizeof(GLuint). --- src/mesa/main/formats.c |2 ++ src/mesa/main/formats.h |8 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a