Re: [Mesa-dev] [PATCH 1/4] llvmpipe: fix using wrong format with MRT in blend code

2013-01-14 Thread Roland Scheidegger
On 01/14/2013 09:44 AM, Brian Paul wrote: IIRC, we can have a mixture of color buffer formats when there's multiple render targets. This change doesn't effect that, right? Well it does - it should fix some edge cases there. We actually did some changes to the color mask of the blend state depe

Re: [Mesa-dev] [PATCH 1/4] llvmpipe: fix using wrong format with MRT in blend code

2013-01-14 Thread Brian Paul
IIRC, we can have a mixture of color buffer formats when there's multiple render targets. This change doesn't effect that, right? Looks OK otherwise. Reviewed-by: Brian Paul On 01/12/2013 05:29 PM, srol...@vmware.com wrote: From: Roland Scheidegger We were passing in the rt index however

[Mesa-dev] [PATCH 1/4] llvmpipe: fix using wrong format with MRT in blend code

2013-01-12 Thread sroland
From: Roland Scheidegger We were passing in the rt index however this was always 0 for non-independent blend case. (The format was only actually used to decide if the color mask covered all channels so this went unnoticed and was discovered by accident.) Additionally, there was a second problem b