Re: [Mesa-dev] [PATCH 1/4] i965: Split out brw__populate_key into their own functions

2015-03-29 Thread Kenneth Graunke
On Friday, March 20, 2015 05:49:06 PM Carl Worth wrote: > This commit splits portions of the existing brw_upload_vs_prog and > brw_upload_gs_prog function into new brw_vs_populate_key and > brw_gs_populate_key functions. This follows the same style as is > already present for all other stages, (see

Re: [Mesa-dev] [PATCH 1/4] i965: Split out brw__populate_key into their own functions

2015-03-20 Thread Carl Worth
On Fri, Mar 20 2015, Ian Romanick wrote: >> +brw_gs_populate_key(struct brw_context *brw, >> +struct brw_gs_prog_key *key) > > Tabs. There may be some in other places too. Thunderbird's editor > isn't "too smart" to be able to search for tabs... it matches any > whitespace. Sorry

Re: [Mesa-dev] [PATCH 1/4] i965: Split out brw__populate_key into their own functions

2015-03-20 Thread Ian Romanick
On 03/20/2015 05:49 PM, Carl Worth wrote: > This commit splits portions of the existing brw_upload_vs_prog and > brw_upload_gs_prog function into new brw_vs_populate_key and > brw_gs_populate_key functions. This follows the same style as is > already present for all other stages, (see brw_wm_popula

[Mesa-dev] [PATCH 1/4] i965: Split out brw__populate_key into their own functions

2015-03-20 Thread Carl Worth
This commit splits portions of the existing brw_upload_vs_prog and brw_upload_gs_prog function into new brw_vs_populate_key and brw_gs_populate_key functions. This follows the same style as is already present for all other stages, (see brw_wm_populate_key, etc.). This commit is intended to have no