Re: [Mesa-dev] [PATCH 1/3] vl: Only initialize vlc once

2011-12-23 Thread Andy Furniss
Maarten Lankhorst wrote: Feel free to commit the result with those 3 changes without further review. :) Mesa master is now failing with everything again for me (with -vc ffmpeg12vdpau ) vl/vl_vlc.h:228:vl_vlc_eatbits: Assertion `vl_vlc_valid_bits(vlc) <= num_bits' failed. __

Re: [Mesa-dev] [PATCH 1/3] vl: Only initialize vlc once

2011-12-23 Thread Maarten Lankhorst
On 12/22/2011 02:25 PM, Christian König wrote: > Hi Maarten, > > On 21.12.2011 21:52, Maarten Lankhorst wrote: >> It would be nice if you inlined patches for easier reviewing. :) > Well I can try, but I can't promise that Thunderbird isn't badly fucking up > all whitespaces, newest version of the

Re: [Mesa-dev] [PATCH 1/3] vl: Only initialize vlc once

2011-12-22 Thread Christian König
Hi Maarten, On 21.12.2011 21:52, Maarten Lankhorst wrote: It would be nice if you inlined patches for easier reviewing. :) Well I can try, but I can't promise that Thunderbird isn't badly fucking up all whitespaces, newest version of the patch is in-lined below. I'm spotting an overflow that

Re: [Mesa-dev] [PATCH 1/3] vl: Only initialize vlc once

2011-12-21 Thread Maarten Lankhorst
On 12/21/2011 08:25 PM, Maarten Lankhorst wrote: > Hey Christian, > > On 12/21/2011 07:25 PM, Christian König wrote: >> Hi guys, >> >> On 21.12.2011 17:27, Maarten Lankhorst wrote: >>> Also a remark about your patch, wish you had inlined it.. >> Sorry, not at home right now and I can't get this Thu

Re: [Mesa-dev] [PATCH 1/3] vl: Only initialize vlc once

2011-12-21 Thread Maarten Lankhorst
Hey Christian, On 12/21/2011 07:25 PM, Christian König wrote: > Hi guys, > > On 21.12.2011 17:27, Maarten Lankhorst wrote: >> Also a remark about your patch, wish you had inlined it.. > Sorry, not at home right now and I can't get this Thunderbird here to inline > the patches correctly. > >> diff

Re: [Mesa-dev] [PATCH 1/3] vl: Only initialize vlc once

2011-12-21 Thread Christian König
Hi guys, On 21.12.2011 17:27, Maarten Lankhorst wrote: Also a remark about your patch, wish you had inlined it.. Sorry, not at home right now and I can't get this Thunderbird here to inline the patches correctly. diff --git a/src/gallium/auxiliary/vl/vl_vlc.h b/src/gallium/auxiliary/vl/vl_v

Re: [Mesa-dev] [PATCH 1/3] vl: Only initialize vlc once

2011-12-21 Thread Maarten Lankhorst
Also a remark about your patch, wish you had inlined it.. On 12/21/2011 04:41 PM, Christian König wrote: > On 20.12.2011 19:20, Maarten Lankhorst wrote: >> Hey Christian, >> >> On 12/20/2011 02:16 PM, Christian König wrote: >>> >>> Why do you want to change that anyway? >>> >>> The search for star

Re: [Mesa-dev] [PATCH 1/3] vl: Only initialize vlc once

2011-12-21 Thread Younes Manton
2011/12/21 Maarten Lankhorst : > Hey Christian, > > On 12/21/2011 04:41 PM, Christian König wrote: >> Those functions are called a couple of million times a second, so even if >> the assertion is only tested in debug builds it has quite an effect on >> performance, sometimes even masquerading rea

Re: [Mesa-dev] [PATCH 1/3] vl: Only initialize vlc once

2011-12-21 Thread Maarten Lankhorst
Hey Christian, On 12/21/2011 04:41 PM, Christian König wrote: > On 20.12.2011 19:20, Maarten Lankhorst wrote: >> Hey Christian, >> >> On 12/20/2011 02:16 PM, Christian König wrote: >>> >>> Why do you want to change that anyway? >>> >>> The search for start codes was especially split out of the VLC

Re: [Mesa-dev] [PATCH 1/3] vl: Only initialize vlc once

2011-12-21 Thread Christian König
On 20.12.2011 19:20, Maarten Lankhorst wrote: Hey Christian, On 12/20/2011 02:16 PM, Christian König wrote: Why do you want to change that anyway? The search for start codes was especially split out of the VLC stuff, because start codes start are byte aligned anyway and it doesn't make much

Re: [Mesa-dev] [PATCH 1/3] vl: Only initialize vlc once

2011-12-21 Thread Maarten Lankhorst
Hey Christian, On 12/20/2011 09:08 PM, Lucas Stach wrote: > Hi all! > Just jumping in with regard to the assert. > > Am Dienstag, den 20.12.2011, 19:20 +0100 schrieb Maarten Lankhorst: > [snip] return vlc->buffer>> (64 - num_bits); } @@ -130,7 +132,7 @@ vl_vlc_peekbits(struc

Re: [Mesa-dev] [PATCH 1/3] vl: Only initialize vlc once

2011-12-20 Thread Lucas Stach
Hi all! Just jumping in with regard to the assert. Am Dienstag, den 20.12.2011, 19:20 +0100 schrieb Maarten Lankhorst: [snip] > > > >> > >> return vlc->buffer>> (64 - num_bits); > >> } > >> @@ -130,7 +132,7 @@ vl_vlc_peekbits(struct vl_vlc *vlc, unsigned num_bits) > >> static INLINE void

Re: [Mesa-dev] [PATCH 1/3] vl: Only initialize vlc once

2011-12-20 Thread Maarten Lankhorst
Hey Christian, On 12/20/2011 02:16 PM, Christian König wrote: > On 20.12.2011 12:43, Maarten Lankhorst wrote: >> And add more sanity checks to stream. This shouldn't break things beyond >> those that aren't broken already. >> >> Signed-off-by: Maarten Lankhorst >> >> --- >> And yes Andy, I mean t

Re: [Mesa-dev] [PATCH 1/3] vl: Only initialize vlc once

2011-12-20 Thread Christian König
On 20.12.2011 12:43, Maarten Lankhorst wrote: And add more sanity checks to stream. This shouldn't break things beyond those that aren't broken already. Signed-off-by: Maarten Lankhorst --- And yes Andy, I mean that I haven't found a good video yet to fix the playback parts that are still bro

[Mesa-dev] [PATCH 1/3] vl: Only initialize vlc once

2011-12-20 Thread Maarten Lankhorst
And add more sanity checks to stream. This shouldn't break things beyond those that aren't broken already. Signed-off-by: Maarten Lankhorst --- And yes Andy, I mean that I haven't found a good video yet to fix the playback parts that are still broken.. src/gallium/auxiliary/vl/vl_mpeg12_bits