Re: [Mesa-dev] [PATCH 1/3] st/mesa/i965: Allow decompressing ETC2 to GL_RGBA

2018-06-22 Thread Tomeu Vizoso
On 06/20/2018 02:57 PM, emil.veli...@collabora.com wrote: Hi Tomeu, On Wed, May 23, 2018 at 10:54:06AM +0200, Tomeu Vizoso wrote: --- a/src/mesa/main/texcompress_etc.h +++ b/src/mesa/main/texcompress_etc.h @@ -28,6 +28,7 @@ #include "glheader.h" #include "texcompress.h" #include "texstor

Re: [Mesa-dev] [PATCH 1/3] st/mesa/i965: Allow decompressing ETC2 to GL_RGBA

2018-06-22 Thread Tomeu Vizoso
On 18 June 2018 at 23:19, Marek Olšák wrote: > What about non-sRGB formats? Only sRGB formats get unpacked to BGRA currently, so I don't need to do anything about the others. Thanks, Tomeu > Marek > > On Wed, May 23, 2018 at 4:54 AM, Tomeu Vizoso > wrote: >> >> When Mesa itself implements ETC

Re: [Mesa-dev] [PATCH 1/3] st/mesa/i965: Allow decompressing ETC2 to GL_RGBA

2018-06-20 Thread emil . velikov
Hi Tomeu, On Wed, May 23, 2018 at 10:54:06AM +0200, Tomeu Vizoso wrote: > --- a/src/mesa/main/texcompress_etc.h > +++ b/src/mesa/main/texcompress_etc.h > @@ -28,6 +28,7 @@ > #include "glheader.h" > #include "texcompress.h" > #include "texstore.h" > +#include "pipe/p_format.h" > Gallium include

Re: [Mesa-dev] [PATCH 1/3] st/mesa/i965: Allow decompressing ETC2 to GL_RGBA

2018-06-18 Thread Marek Olšák
What about non-sRGB formats? Marek On Wed, May 23, 2018 at 4:54 AM, Tomeu Vizoso wrote: > When Mesa itself implements ETC2 decompression, it currently > decompresses to formats in the GL_BGRA component order. > > That can be problematic for drivers which cannot upload the texture data > as GL_B

[Mesa-dev] [PATCH 1/3] st/mesa/i965: Allow decompressing ETC2 to GL_RGBA

2018-05-23 Thread Tomeu Vizoso
When Mesa itself implements ETC2 decompression, it currently decompresses to formats in the GL_BGRA component order. That can be problematic for drivers which cannot upload the texture data as GL_BGRA, such as Virgl when it's backed by GLES on the host. So this commit adds a flag to _mesa_unpack_