Re: [Mesa-dev] [PATCH 1/3] panfrost: Print a backtrace if there is one

2019-06-24 Thread Tomeu Vizoso
On Mon, 24 Jun 2019 at 12:00, Rohan Garg wrote: > > > I think assertions should be limited to the most basic of sanity checks, > > and the other asserts replaced by proper error handling. > > So, should I leave it as is and let us hit assertions that we fix? Sorry, can you rephrase? Thanks, Tom

Re: [Mesa-dev] [PATCH 1/3] panfrost: Print a backtrace if there is one

2019-06-24 Thread Rohan Garg
> I think assertions should be limited to the most basic of sanity checks, > and the other asserts replaced by proper error handling. So, should I leave it as is and let us hit assertions that we fix? Cheers Rohan Garg signature.asc Description: This is a digitally signed message part. _

Re: [Mesa-dev] [PATCH 1/3] panfrost: Print a backtrace if there is one

2019-06-21 Thread Tomeu Vizoso
On 6/21/19 12:23 PM, Rohan Garg wrote: Hey Good stuff, but isn't this change making us hit assertions? Hm, I thought it only enabled debugging symbols. Do you have a recommendation on how to enable debug symbols but not enabling assertions? I think assertions should be limited to the most ba

Re: [Mesa-dev] [PATCH 1/3] panfrost: Print a backtrace if there is one

2019-06-21 Thread Rohan Garg
Hey > Good stuff, but isn't this change making us hit assertions? Hm, I thought it only enabled debugging symbols. Do you have a recommendation on how to enable debug symbols but not enabling assertions? Cheers Rohan Garg ___ mesa-dev mailing list me

Re: [Mesa-dev] [PATCH 1/3] panfrost: Print a backtrace if there is one

2019-06-20 Thread Tomeu Vizoso
On Thu, 20 Jun 2019 at 15:59, Rohan Garg wrote: > > --- > src/gallium/drivers/panfrost/ci/create-rootfs.sh | 2 +- > src/gallium/drivers/panfrost/ci/deqp-runner.sh | 6 ++ > src/gallium/drivers/panfrost/ci/gitlab-ci.yml| 4 ++-- > src/gallium/drivers/panfrost/ci/lava-deqp.ym

[Mesa-dev] [PATCH 1/3] panfrost: Print a backtrace if there is one

2019-06-20 Thread Rohan Garg
--- src/gallium/drivers/panfrost/ci/create-rootfs.sh | 2 +- src/gallium/drivers/panfrost/ci/deqp-runner.sh | 6 ++ src/gallium/drivers/panfrost/ci/gitlab-ci.yml| 4 ++-- src/gallium/drivers/panfrost/ci/lava-deqp.yml.jinja2 | 3 +++ 4 files changed, 12 insertions(+), 3 deleti