Re: [Mesa-dev] [PATCH 1/3] panfrost: Move ra_regs to the screen context

2019-06-20 Thread Alyssa Rosenzweig
Oh, this looks lovely! Thank you! One concern I have is that we're leaking work_vec* for REGS_VARIANTS_COUNT-1 variants, since we reinitialize those classes for each RA variant (I believe that is correct behaviour) but only store the last one (I believe that is incorrect). Perhaps we should make

[Mesa-dev] [PATCH 1/3] panfrost: Move ra_regs to the screen context

2019-06-20 Thread Tomeu Vizoso
Signed-off-by: Tomeu Vizoso --- .../drivers/panfrost/midgard/compiler.h | 2 + .../panfrost/midgard/midgard_compile.c| 13 +- .../panfrost/midgard/midgard_compile.h| 17 ++- .../drivers/panfrost/midgard/midgard_ra.c | 116 ++ .../panfrost/midgard/midg