Re: [Mesa-dev] [PATCH 1/3] nv50/ir: support different unordered_set implementations

2015-06-19 Thread Ilia Mirkin
On Fri, Jun 19, 2015 at 1:19 PM, Chih-Wei Huang wrote: > 2015-06-20 1:01 GMT+08:00 Ilia Mirkin : >> Wouldn't it be simpler to just have >> >> codegen/unordered_set.h >> >> which in turn has all the odd logic? I'm definitely a tad unhappy >> about adding "using" in a header, but if the using goes i

Re: [Mesa-dev] [PATCH 1/3] nv50/ir: support different unordered_set implementations

2015-06-19 Thread Chih-Wei Huang
2015-06-20 1:01 GMT+08:00 Ilia Mirkin : > Wouldn't it be simpler to just have > > codegen/unordered_set.h > > which in turn has all the odd logic? I'm definitely a tad unhappy > about adding "using" in a header, but if the using goes inside the > nv50_ir namespace, I'm less weirded out by it. And t

Re: [Mesa-dev] [PATCH 1/3] nv50/ir: support different unordered_set implementations

2015-06-19 Thread Ilia Mirkin
Wouldn't it be simpler to just have codegen/unordered_set.h which in turn has all the odd logic? I'm definitely a tad unhappy about adding "using" in a header, but if the using goes inside the nv50_ir namespace, I'm less weirded out by it. And then effectively all 3 become nv50_ir::unordered_set,

[Mesa-dev] [PATCH 1/3] nv50/ir: support different unordered_set implementations

2015-06-19 Thread Chih-Wei Huang
If build with C++11 standard, use std::unordered_set. Otherwise if build on old Android version with stlport, use std::tr1::unordered_set with a wrapper class. Otherwise use std::tr1::unordered_set. Signed-off-by: Chih-Wei Huang --- Android.common.mk | 1 + sr