Re: [Mesa-dev] [PATCH 1/3] mesa: rework error handling in glDrawBuffers

2019-05-01 Thread Mathias Fröhlich
Hi Marek, On Tuesday, 30 April 2019 01:10:42 CEST Marek Olšák wrote: > I'm adding this hunk, which makes the test pass: > > diff --git a/src/mesa/main/buffers.c b/src/mesa/main/buffers.c > index 1ac0d5d0798..a46599a2872 100644 > --- a/src/mesa/main/buffers.c > +++ b/src/mesa/main/buffers.c > @@ -

Re: [Mesa-dev] [PATCH 1/3] mesa: rework error handling in glDrawBuffers

2019-04-29 Thread Marek Olšák
I'm adding this hunk, which makes the test pass: diff --git a/src/mesa/main/buffers.c b/src/mesa/main/buffers.c index 1ac0d5d0798..a46599a2872 100644 --- a/src/mesa/main/buffers.c +++ b/src/mesa/main/buffers.c @@ -485,7 +485,9 @@ draw_buffers(struct gl_context *ctx, struct gl_framebuffer *fb, GLsi

Re: [Mesa-dev] [PATCH 1/3] mesa: rework error handling in glDrawBuffers

2019-04-27 Thread Mathias Fröhlich
Hi Marek, one comment/failure inline: On Saturday, 27 April 2019 05:31:45 CEST Marek Olšák wrote: > From: Marek Olšák > > It's needed by the next pbuffer fix, which changes the behavior of > draw_buffer_enum_to_bitmask, so it can't be used to help with error > checking. > --- > src/mesa/main/b

[Mesa-dev] [PATCH 1/3] mesa: rework error handling in glDrawBuffers

2019-04-26 Thread Marek Olšák
From: Marek Olšák It's needed by the next pbuffer fix, which changes the behavior of draw_buffer_enum_to_bitmask, so it can't be used to help with error checking. --- src/mesa/main/buffers.c | 53 ++--- 1 file changed, 29 insertions(+), 24 deletions(-) diff -