Re: [Mesa-dev] [PATCH 1/3] glx: Implement the libglvnd interface.

2016-05-12 Thread Adam Jackson
On Thu, 2016-05-12 at 19:58 +0100, Emil Velikov wrote: > > In dispatch_ChooseFBConfigSGIX, if AddFBConfigsMapping fails, should it use > > free or XFree to free the memory? > > > In theory it should be XFree(). In practise that one has been a > wrapper around free() for a long time so I've went w

Re: [Mesa-dev] [PATCH 1/3] glx: Implement the libglvnd interface.

2016-05-12 Thread Chuck Atkins
> > +if test "x$enable_glx" = xno; then > +AC_MSG_ERROR([cannot build libglvnd without GLX]) > +fi > + > +if test "x$enable_xlib_glx" = xyes; then > +AC_MSG_ERROR([cannot build libgvnd when Xlib-GLX is enabled]) > +fi > This doesn't consider the gallium-xlib impleme

Re: [Mesa-dev] [PATCH 1/3] glx: Implement the libglvnd interface.

2016-05-12 Thread Kyle Brenneman
On 05/12/2016 12:58 PM, Emil Velikov wrote: Hi all, On 11 May 2016 at 19:53, Kyle Brenneman wrote: In the GLX dispatch functions, it should be safe to ignore a failed call to AddDrawableMapping. If it can't update the drawable-to-vendor hashtable at that point, then libGLX will just query the

Re: [Mesa-dev] [PATCH 1/3] glx: Implement the libglvnd interface.

2016-05-12 Thread Emil Velikov
Hi all, On 11 May 2016 at 19:53, Kyle Brenneman wrote: > In the GLX dispatch functions, it should be safe to ignore a failed call to > AddDrawableMapping. If it can't update the drawable-to-vendor hashtable at > that point, then libGLX will just query the server when it needs to figure > out the

Re: [Mesa-dev] [PATCH 1/3] glx: Implement the libglvnd interface.

2016-05-11 Thread Kyle Brenneman
In the GLX dispatch functions, it should be safe to ignore a failed call to AddDrawableMapping. If it can't update the drawable-to-vendor hashtable at that point, then libGLX will just query the server when it needs to figure out the vendor. In dispatch_ChooseFBConfigSGIX, if AddFBConfigsMappi

[Mesa-dev] [PATCH 1/3] glx: Implement the libglvnd interface.

2016-05-11 Thread Adam Jackson
From: Kyle Brenneman With reference to the libglvnd branch: https://cgit.freedesktop.org/mesa/mesa/log/?h=libglvnd This is a squashed commit containing all of Kyle's commits, all but two of Emil's commits (to follow), and a small fixup from myself to mark the rest of the glX* functions as _GLX_