Re: [Mesa-dev] [PATCH 1/3] glcpp: Only warn for macro names containing __

2014-02-19 Thread Darius Spitznagel
Am 19.02.2014 20:09, schrieb Ian Romanick: I'm hoping that Tapani or Darius will verify that this patch actually fixes the problem. That's why people CC other people on patches. :) On 02/18/2014 10:19 AM, Ian Romanick wrote: From: Ian Romanick Section 3.3 (Preprocessor) of the GLSL 1.30 spec

Re: [Mesa-dev] [PATCH 1/3] glcpp: Only warn for macro names containing __

2014-02-19 Thread Kenneth Graunke
On 02/19/2014 11:09 AM, Ian Romanick wrote: > I'm hoping that Tapani or Darius will verify that this patch actually > fixes the problem. That's why people CC other people on patches. :) I have the game, and I can confirm that the lighting is awfully broken with master, and looks correct after thi

Re: [Mesa-dev] [PATCH 1/3] glcpp: Only warn for macro names containing __

2014-02-19 Thread Ian Romanick
I'm hoping that Tapani or Darius will verify that this patch actually fixes the problem. That's why people CC other people on patches. :) On 02/18/2014 10:19 AM, Ian Romanick wrote: > From: Ian Romanick > > Section 3.3 (Preprocessor) of the GLSL 1.30 spec (and later) and the > GLSL ES spec (all

[Mesa-dev] [PATCH 1/3] glcpp: Only warn for macro names containing __

2014-02-18 Thread Ian Romanick
From: Ian Romanick Section 3.3 (Preprocessor) of the GLSL 1.30 spec (and later) and the GLSL ES spec (all versions) say: "All macro names containing two consecutive underscores ( __ ) are reserved for future use as predefined macro names. All macro names prefixed with "GL_" ("GL" fol