Re: [Mesa-dev] [PATCH 1/3] gallium/st: add pipe_context::generate_mipmap()

2016-01-12 Thread Michel Dänzer
On 13.01.2016 04:20, Charmaine Lee wrote: > >> From: Michel Dänzer >> Sent: Monday, January 11, 2016 11:37 PM >> To: Charmaine Lee >> Cc: mesa-dev@lists.freedesktop.org >> Subject: Re: [Mesa-dev] [PATCH 1/3] gallium/st: add >> pipe_context::generate_mipmap

Re: [Mesa-dev] [PATCH 1/3] gallium/st: add pipe_context::generate_mipmap()

2016-01-12 Thread Charmaine Lee
>From: Michel Dänzer >Sent: Monday, January 11, 2016 11:37 PM >To: Charmaine Lee >Cc: mesa-dev@lists.freedesktop.org >Subject: Re: [Mesa-dev] [PATCH 1/3] gallium/st: add >pipe_context::generate_mipmap() >On 12.01.2016 15:18, Charmaine Lee wrote: >> This patch adds

Re: [Mesa-dev] [PATCH 1/3] gallium/st: add pipe_context::generate_mipmap()

2016-01-12 Thread Brian Paul
Just a few nit-picks below... On 01/11/2016 11:18 PM, Charmaine Lee wrote: This patch adds a new interface to support hardware mipmap generation. PIPE_CAP_GENERATE_MIPMAP is added to allow a driver to specify if this new interface is supported; if not supported, the state tracker will fallback

Re: [Mesa-dev] [PATCH 1/3] gallium/st: add pipe_context::generate_mipmap()

2016-01-12 Thread Axel Davy
On 12/01/2016 07:18, Charmaine Lee wrote: --- a/src/mesa/state_tracker/st_gen_mipmap.c +++ b/src/mesa/state_tracker/st_gen_mipmap.c @@ -149,12 +149,19 @@ st_generate_mipmap(struct gl_context *ctx, GLenum target, last_layer = util_max_layer(pt, baseLevel); } - /* Try to generate

Re: [Mesa-dev] [PATCH 1/3] gallium/st: add pipe_context::generate_mipmap()

2016-01-11 Thread Michel Dänzer
On 12.01.2016 15:18, Charmaine Lee wrote: > This patch adds a new interface to support hardware mipmap generation. > PIPE_CAP_GENERATE_MIPMAP is added to allow a driver to specify > if this new interface is supported; if not supported, the state tracker will > fallback to mipmap generation by rende

[Mesa-dev] [PATCH 1/3] gallium/st: add pipe_context::generate_mipmap()

2016-01-11 Thread Charmaine Lee
This patch adds a new interface to support hardware mipmap generation. PIPE_CAP_GENERATE_MIPMAP is added to allow a driver to specify if this new interface is supported; if not supported, the state tracker will fallback to mipmap generation by rendering/texturing. v2: add PIPE_CAP_GENERATE_MIPMAP

Re: [Mesa-dev] [PATCH 1/3] gallium/st: add pipe_context::generate_mipmap()

2016-01-11 Thread Charmaine Lee
>From: ibmir...@gmail.com on behalf of Ilia Mirkin > >Sent: Monday, January 11, 2016 7:12 PM >To: Charmaine Lee >Cc: mesa-dev@lists.freedesktop.org >Subject: Re: [Mesa-dev] [PATCH 1/3] gallium/st: add >pipe_context::generate_mipmap() >On Mon, Jan 11, 2016 at 9:31

Re: [Mesa-dev] [PATCH 1/3] gallium/st: add pipe_context::generate_mipmap()

2016-01-11 Thread Ilia Mirkin
On Mon, Jan 11, 2016 at 9:31 PM, Charmaine Lee wrote: > This patch adds a new interface to support hardware mipmap generation. > PIPE_CAP_GENERATE_MIPMAP is added to allow a driver to specify > if this new interface is supported; if not supported, the state tracker will > fallback to mipmap genera

[Mesa-dev] [PATCH 1/3] gallium/st: add pipe_context::generate_mipmap()

2016-01-11 Thread Charmaine Lee
This patch adds a new interface to support hardware mipmap generation. PIPE_CAP_GENERATE_MIPMAP is added to allow a driver to specify if this new interface is supported; if not supported, the state tracker will fallback to mipmap generation by rendering/texturing. --- src/gallium/docs/source/conte