On 24 July 2017 at 12:46, Emil Velikov wrote:
> On 24 July 2017 at 12:22, Daniel Stone wrote:
>> It's divergent inside Gallium, where resource_create_with_modifiers
>> will be called rather than resource_create if modifiers != NULL.
>>
> Excuse my ignorance, I must be having a really stupid momen
On 24 July 2017 at 12:22, Daniel Stone wrote:
> Hi Emil,
>
> On 24 July 2017 at 12:18, Emil Velikov wrote:
>> On 21 July 2017 at 14:34, Daniel Stone wrote:
>>> @@ -370,6 +370,9 @@ get_back_bo(struct dri2_egl_surface *dri2_surf)
>>>return -1;
>>> }
>>>
>>> + if (num_modifiers == 0)
Hi Emil,
On 24 July 2017 at 12:18, Emil Velikov wrote:
> On 21 July 2017 at 14:34, Daniel Stone wrote:
>> @@ -370,6 +370,9 @@ get_back_bo(struct dri2_egl_surface *dri2_surf)
>>return -1;
>> }
>>
>> + if (num_modifiers == 0)
>> + modifiers = NULL;
>> +
> AFAICT this hunk is not
On 21 July 2017 at 14:34, Daniel Stone wrote:
> If the underlying driver does not support modifiers, dmabuf will still
> advertise formats through the 'modifier' event, but send them with an
> invalid modifier. Ignore them if this is the case, rather than passing
> them through to the driver.
>
>
If the underlying driver does not support modifiers, dmabuf will still
advertise formats through the 'modifier' event, but send them with an
invalid modifier. Ignore them if this is the case, rather than passing
them through to the driver.
Signed-off-by: Daniel Stone
Fixes: 02cc35937277 ("egl/way
