Re: [Mesa-dev] [PATCH 1/3] egl/sl: split out swrast probe into separate function

2019-02-19 Thread Emil Velikov
On Mon, 18 Feb 2019 at 16:07, Eric Engestrom wrote: > > On Tuesday, 2019-02-05 15:31:06 +, Emil Velikov wrote: > > From: Emil Velikov > > > > Make the code a bit easier to read. > > > > As a bonus point this makes it obvious that we forgot to call > > _eglAddDevice() for the device - do so. >

Re: [Mesa-dev] [PATCH 1/3] egl/sl: split out swrast probe into separate function

2019-02-18 Thread Eric Engestrom
On Tuesday, 2019-02-05 15:31:06 +, Emil Velikov wrote: > From: Emil Velikov > > Make the code a bit easier to read. > > As a bonus point this makes it obvious that we forgot to call > _eglAddDevice() for the device - do so. > > Signed-off-by: Emil Velikov > --- > src/egl/drivers/dri2/plat

Re: [Mesa-dev] [PATCH 1/3] egl/sl: split out swrast probe into separate function

2019-02-17 Thread Mathias Fröhlich
Emil, indeed this is easier to read. For patch #1 and #2 you get Reviewed-by: Mathias Fröhlich For patch #3, I don't know vgem good enough to judge the big picture. The change within mesa itself looks technically correct. best Mathias On Tuesday, 5 February 2019 16:31:06 CET Emil Velikov

[Mesa-dev] [PATCH 1/3] egl/sl: split out swrast probe into separate function

2019-02-05 Thread Emil Velikov
From: Emil Velikov Make the code a bit easier to read. As a bonus point this makes it obvious that we forgot to call _eglAddDevice() for the device - do so. Signed-off-by: Emil Velikov --- src/egl/drivers/dri2/platform_surfaceless.c | 46 - 1 file changed, 27 insertions(+)