Re: [Mesa-dev] [PATCH 1/2] vc4: use util_copy_framebuffer_state

2018-05-14 Thread Eric Anholt
Rob Clark writes: > On Mon, May 14, 2018 at 9:16 AM, Rob Clark wrote: >> Signed-off-by: Rob Clark >> --- >> Just happened to notice that vc4/vc5 was open-coding >> util_copy_framebuffer_state() > > and ofc if I actually managed to test-compile what I *thought* I was > compiling, I would have no

Re: [Mesa-dev] [PATCH 1/2] vc4: use util_copy_framebuffer_state

2018-05-14 Thread Rob Clark
On Mon, May 14, 2018 at 9:16 AM, Rob Clark wrote: > Signed-off-by: Rob Clark > --- > Just happened to notice that vc4/vc5 was open-coding > util_copy_framebuffer_state() and ofc if I actually managed to test-compile what I *thought* I was compiling, I would have noticed the missing #include and

[Mesa-dev] [PATCH 1/2] vc4: use util_copy_framebuffer_state

2018-05-14 Thread Rob Clark
Signed-off-by: Rob Clark --- Just happened to notice that vc4/vc5 was open-coding util_copy_framebuffer_state() src/gallium/drivers/vc4/vc4_state.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/src/gallium/drivers/vc4/vc4_state.c b/src/gallium/drivers/vc4/vc4_