Re: [Mesa-dev] [PATCH 1/2] svga: fix context alloc error handling

2018-01-25 Thread Emil Velikov
On 23 January 2018 at 18:02, Brian Paul wrote: > On 01/22/2018 03:41 PM, Grazvydas Ignotas wrote: >> >> 'cleanup' path is dereferencing 'svga' a lot, 'done' is a better choice. >> Found by Coccinelle. >> >> Signed-off-by: Grazvydas Ignotas >> --- >> src/gallium/drivers/svga/svga_context.c | 2 +

Re: [Mesa-dev] [PATCH 1/2] svga: fix context alloc error handling

2018-01-23 Thread Brian Paul
On 01/22/2018 03:41 PM, Grazvydas Ignotas wrote: 'cleanup' path is dereferencing 'svga' a lot, 'done' is a better choice. Found by Coccinelle. Signed-off-by: Grazvydas Ignotas --- src/gallium/drivers/svga/svga_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/

Re: [Mesa-dev] [PATCH 1/2] svga: fix context alloc error handling

2018-01-23 Thread Eric Engestrom
On Tuesday, 2018-01-23 00:41:22 +0200, Grazvydas Ignotas wrote: > 'cleanup' path is dereferencing 'svga' a lot, 'done' is a better choice. > Found by Coccinelle. > > Signed-off-by: Grazvydas Ignotas Both patches are Reviewed-by: Eric Engestrom > --- > src/gallium/drivers/svga/svga_context.c |

[Mesa-dev] [PATCH 1/2] svga: fix context alloc error handling

2018-01-22 Thread Grazvydas Ignotas
'cleanup' path is dereferencing 'svga' a lot, 'done' is a better choice. Found by Coccinelle. Signed-off-by: Grazvydas Ignotas --- src/gallium/drivers/svga/svga_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/svga/svga_context.c b/src/gallium/dr