Re: [Mesa-dev] [PATCH 1/2] st-api: Rework how drawables are invalidated

2011-06-29 Thread Thomas Hellstrom
Jon, Thanks for pointing this out. I apparently missed at least one case. I'll fix ASAP. /Thomas On 06/29/2011 02:20 PM, Jon TURNEY wrote: On 28/06/2011 13:19, Thomas Hellstrom wrote: The api and the state tracker manager code as well as the state tracker code assumed that only a single c

Re: [Mesa-dev] [PATCH 1/2] st-api: Rework how drawables are invalidated

2011-06-29 Thread Jon TURNEY
On 28/06/2011 13:19, Thomas Hellstrom wrote: > The api and the state tracker manager code as well as the state tracker code > assumed that only a single context could be bound to a drawable. That is not > a valid assumption, since multiple contexts can bind to the same drawable. > > Fix this by ma

Re: [Mesa-dev] [PATCH 1/2] st-api: Rework how drawables are invalidated

2011-06-28 Thread Thomas Hellstrom
On 06/29/2011 01:26 AM, Chia-I Wu wrote: On Tue, Jun 28, 2011 at 9:19 PM, Thomas Hellstrom wrote: The api and the state tracker manager code as well as the state tracker code assumed that only a single context could be bound to a drawable. That is not a valid assumption, since multiple cont

Re: [Mesa-dev] [PATCH 1/2] st-api: Rework how drawables are invalidated

2011-06-28 Thread Chia-I Wu
On Tue, Jun 28, 2011 at 9:19 PM, Thomas Hellstrom wrote: > The api and the state tracker manager code as well as the state tracker code > assumed that only a single context could be bound to a drawable. That is not > a valid assumption, since multiple contexts can bind to the same drawable. > > Fi

Re: [Mesa-dev] [PATCH 1/2] st-api: Rework how drawables are invalidated

2011-06-28 Thread Thomas Hellstrom
On 06/28/2011 04:27 PM, Jose Fonseca wrote: Looks good to me Thomas. Jose Jakob pointed out that the state trackers (vega & mesa) will actually create a window system draw buffer / framebuffer per context, even if they represent the same window system drawable, so I need to do some fixu

Re: [Mesa-dev] [PATCH 1/2] st-api: Rework how drawables are invalidated

2011-06-28 Thread Jose Fonseca
Looks good to me Thomas. Jose - Original Message - > The api and the state tracker manager code as well as the state > tracker code > assumed that only a single context could be bound to a drawable. That > is not > a valid assumption, since multiple contexts can bind to the same > drawabl

[Mesa-dev] [PATCH 1/2] st-api: Rework how drawables are invalidated

2011-06-28 Thread Thomas Hellstrom
The api and the state tracker manager code as well as the state tracker code assumed that only a single context could be bound to a drawable. That is not a valid assumption, since multiple contexts can bind to the same drawable. Fix this by making it the state tracker's responsibility to update al