Re: [Mesa-dev] [PATCH 1/2] st/mesa: move dereference after null check

2016-03-01 Thread Thomas H.P. Andersen
On Wed, Mar 2, 2016 at 12:33 AM, Brian Paul wrote: > On 03/01/2016 02:45 PM, Thomas Hindoe Paaboel Andersen wrote: > >> We should not dereference shader before we have done the >> null check. >> --- >> src/mesa/state_tracker/st_atom_image.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 delet

Re: [Mesa-dev] [PATCH 1/2] st/mesa: move dereference after null check

2016-03-01 Thread Brian Paul
On 03/01/2016 02:45 PM, Thomas Hindoe Paaboel Andersen wrote: We should not dereference shader before we have done the null check. --- src/mesa/state_tracker/st_atom_image.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_atom_image.c b/src/mes

Re: [Mesa-dev] [PATCH 1/2] st/mesa: move dereference after null check

2016-03-01 Thread Erik Faye-Lund
On Tue, Mar 1, 2016 at 10:45 PM, Thomas Hindoe Paaboel Andersen wrote: > We should not dereference shader before we have done the > null check. > --- > src/mesa/state_tracker/st_atom_image.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/state_tracker/st_atom

[Mesa-dev] [PATCH 1/2] st/mesa: move dereference after null check

2016-03-01 Thread Thomas Hindoe Paaboel Andersen
We should not dereference shader before we have done the null check. --- src/mesa/state_tracker/st_atom_image.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_atom_image.c b/src/mesa/state_tracker/st_atom_image.c index 4b48bc3..d0f0c42 100644 ---