Re: [Mesa-dev] [PATCH 1/2] st/mesa: fix max_offset computation for base vertex

2012-04-05 Thread Brian Paul
On 04/03/2012 01:36 PM, Marek Olšák wrote: On Tue, Apr 3, 2012 at 6:13 PM, Brian Paul wrote: Hi Brian, the !new_array test should stay there, because redefine_user_buffer should only be called if st_validate_varrays wasn't. If new_array is TRUE, we call st_validate_varrays. If it's FALSE, we c

Re: [Mesa-dev] [PATCH 1/2] st/mesa: fix max_offset computation for base vertex

2012-04-03 Thread Marek Olšák
On Tue, Apr 3, 2012 at 6:13 PM, Brian Paul wrote: >> Hi Brian, >> >> the !new_array test should stay there, because redefine_user_buffer >> should only be called if st_validate_varrays wasn't. If new_array is >> TRUE, we call st_validate_varrays. If it's FALSE, we call >> redefine_user_buffer. We

Re: [Mesa-dev] [PATCH 1/2] st/mesa: fix max_offset computation for base vertex

2012-04-03 Thread Brian Paul
On 04/03/2012 10:02 AM, Marek Olšák wrote: On Mon, Apr 2, 2012 at 8:12 PM, Brian Paul wrote: Fixes a failed assertion in the u_upload_mgr.c code with the VMware svga driver. Note that we have to remove the !new_array test because the VBO module always sets _NEW_ARRAY when setting up the draw c

Re: [Mesa-dev] [PATCH 1/2] st/mesa: fix max_offset computation for base vertex

2012-04-03 Thread Marek Olšák
On Mon, Apr 2, 2012 at 8:12 PM, Brian Paul wrote: > Fixes a failed assertion in the u_upload_mgr.c code with the VMware > svga driver.  Note that we have to remove the !new_array test because > the VBO module always sets _NEW_ARRAY when setting up the draw call. > > Fixes https://bugs.freedesktop.

Re: [Mesa-dev] [PATCH 1/2] st/mesa: fix max_offset computation for base vertex

2012-04-03 Thread Jose Fonseca
Looks good to me. Jose - Original Message - > Fixes a failed assertion in the u_upload_mgr.c code with the VMware > svga driver. Note that we have to remove the !new_array test because > the VBO module always sets _NEW_ARRAY when setting up the draw call. > > Fixes https://bugs.freedesk

[Mesa-dev] [PATCH 1/2] st/mesa: fix max_offset computation for base vertex

2012-04-02 Thread Brian Paul
Fixes a failed assertion in the u_upload_mgr.c code with the VMware svga driver. Note that we have to remove the !new_array test because the VBO module always sets _NEW_ARRAY when setting up the draw call. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=48141 --- src/mesa/state_tracker/st_dra