Re: [Mesa-dev] [PATCH 1/2] st/mesa: fix crash in shader cache cased by race condition

2017-02-22 Thread Michel Dänzer
On 23/02/17 12:59 PM, Timothy Arceri wrote: > If a thread doesn't load GLSL IR from cache but does load TGSI > from cache (that was created by another thread) than it will > crash due to expecting gl_program_parameter_list to have been > restored from the GLSL IR cache and not be null. > --- > src

Re: [Mesa-dev] [PATCH 1/2] st/mesa: fix crash in shader cache cased by race condition

2017-02-22 Thread Edward O'Callaghan
1&2 are, Reviewed-by: Edward O'Callaghan On 02/23/2017 02:59 PM, Timothy Arceri wrote: > If a thread doesn't load GLSL IR from cache but does load TGSI > from cache (that was created by another thread) than it will > crash due to expecting gl_program_parameter_list to have been > restored from th

[Mesa-dev] [PATCH 1/2] st/mesa: fix crash in shader cache cased by race condition

2017-02-22 Thread Timothy Arceri
If a thread doesn't load GLSL IR from cache but does load TGSI from cache (that was created by another thread) than it will crash due to expecting gl_program_parameter_list to have been restored from the GLSL IR cache and not be null. --- src/mesa/state_tracker/st_shader_cache.c | 14 -