Re: [Mesa-dev] [PATCH 1/2] st/glsl_to_tgsi: be precise about merging scopes

2017-09-06 Thread Dieter Nützel
For the series: Tested-by: Dieter Nützel Am 06.09.2017 11:54, schrieb Nicolai Hähnle: From: Nicolai Hähnle enclosing_scope already contains enclosing_scope_first_read. What we really want to check here -- not for correctness, but for speed -- is whether last_read_scope already contains enclo

Re: [Mesa-dev] [PATCH 1/2] st/glsl_to_tgsi: be precise about merging scopes

2017-09-06 Thread Gert Wollny
For the series Reviewed-By: Gert Wollny Am Mittwoch, den 06.09.2017, 11:54 +0200 schrieb Nicolai Hähnle: > From: Nicolai Hähnle > > enclosing_scope already contains enclosing_scope_first_read. > What we really want to check here -- not for correctness, but > for speed -- is whether last_read_s

[Mesa-dev] [PATCH 1/2] st/glsl_to_tgsi: be precise about merging scopes

2017-09-06 Thread Nicolai Hähnle
From: Nicolai Hähnle enclosing_scope already contains enclosing_scope_first_read. What we really want to check here -- not for correctness, but for speed -- is whether last_read_scope already contains enclosing_scope. --- src/mesa/state_tracker/st_glsl_to_tgsi_temprename.cpp | 4 ++-- 1 file cha