Re: [Mesa-dev] [PATCH 1/2] radv: enable lowering of nir_op_bitfield_insert

2017-12-06 Thread Samuel Pitoiset
On 12/06/2017 01:04 PM, James Legg wrote: On Tue, 2017-12-05 at 14:24 -0500, Connor Abbott wrote: lower_bitfield_insert lowers nir_op_bitfield_insert to DX10-style nir_op_bfi and nir_op_bfm, both of which aren't handled by ac_nir_to_llvm, so unless I'm missing something this will just break th

Re: [Mesa-dev] [PATCH 1/2] radv: enable lowering of nir_op_bitfield_insert

2017-12-06 Thread James Legg
On Tue, 2017-12-05 at 14:24 -0500, Connor Abbott wrote: > lower_bitfield_insert lowers nir_op_bitfield_insert to DX10-style > nir_op_bfi and nir_op_bfm, both of which aren't handled by > ac_nir_to_llvm, so unless I'm missing something this will just break > them even harder. We probably should use

Re: [Mesa-dev] [PATCH 1/2] radv: enable lowering of nir_op_bitfield_insert

2017-12-05 Thread Connor Abbott
lower_bitfield_insert lowers nir_op_bitfield_insert to DX10-style nir_op_bfi and nir_op_bfm, both of which aren't handled by ac_nir_to_llvm, so unless I'm missing something this will just break them even harder. We probably should use this lowering after adding support for bfi and bfm, since AMD do

[Mesa-dev] [PATCH 1/2] radv: enable lowering of nir_op_bitfield_insert

2017-12-05 Thread Samuel Pitoiset
Otherwise it's replaced by "vec1 32 ssa_108 = load_const (0x /* 0.00 */)", which looks clearly wrong. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104119 Signed-off-by: Samuel Pitoiset --- src/amd/vulkan/radv_shader.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/