Re: [Mesa-dev] [PATCH 1/2] radeonsi: Lock a mutex when checking scratch relocations.

2016-05-01 Thread Michel Dänzer
On 22.04.2016 17:19, Marek Olšák wrote: > On Fri, Apr 22, 2016 at 6:41 AM, Nicolai Hähnle wrote: >> >> (Curiously, there is an old "this is probably not needed anymore" comment on >> the PS_PARTIAL_FLUSH in si_context_gfx_flush, but this may be wrong: since >> shaders can write memory, and the ker

Re: [Mesa-dev] [PATCH 1/2] radeonsi: Lock a mutex when checking scratch relocations.

2016-04-22 Thread Marek Olšák
On Fri, Apr 22, 2016 at 6:41 AM, Nicolai Hähnle wrote: > On 21.04.2016 13:51, Bas Nieuwenhuizen wrote: >> >> We can use shaders from multiple contexts, and they were not >> otherwise locked yet. > > > Ouch... I guess this is why compute scratch buffers used to be per-program? > > I'm still trying

Re: [Mesa-dev] [PATCH 1/2] radeonsi: Lock a mutex when checking scratch relocations.

2016-04-21 Thread Nicolai Hähnle
On 21.04.2016 13:51, Bas Nieuwenhuizen wrote: We can use shaders from multiple contexts, and they were not otherwise locked yet. Ouch... I guess this is why compute scratch buffers used to be per-program? I'm still trying to wrap my head around the possible code paths here... are you sure tha

[Mesa-dev] [PATCH 1/2] radeonsi: Lock a mutex when checking scratch relocations.

2016-04-21 Thread Bas Nieuwenhuizen
We can use shaders from multiple contexts, and they were not otherwise locked yet. Signed-off-by: Bas Nieuwenhuizen --- src/gallium/drivers/radeonsi/si_compute.c | 20 src/gallium/drivers/radeonsi/si_state_shaders.c | 12 ++-- 2 files changed, 26 insertions(+),