Re: [Mesa-dev] [PATCH 1/2] r600: make condition clearer

2017-03-20 Thread Constantine Kharlamov
I resent, though the rebase is unneeded, r600_asm.c didn't see a change for more than year. On 20.03.2017 14:45, Dieter Nützel wrote: > Hello Constantine, > > 1/1 > - rebase needed > - line wrap needed > apart from that: > Tested-by: Dieter Nützel > > 1/2 > Acked-by: Dieter Nützel > > @Marek

Re: [Mesa-dev] [PATCH 1/2] r600: make condition clearer

2017-03-20 Thread Dieter Nützel
Hello Constantine, 1/1 - rebase needed - line wrap needed apart from that: Tested-by: Dieter Nützel 1/2 Acked-by: Dieter Nützel @Marek: There are several r600/r600g patches/fixes floating around. I'll try to test all and who is responsible for them (r600g) and commit them later on? Greetin

[Mesa-dev] [PATCH 1/2] r600: make condition clearer

2017-03-19 Thread Constantine Kharlamov
The second check in the old code looked pretty much unreachable, esp. because it's not obvious that "max_entries" could be zero. To find out that it was intentional I had to run some checks, and to dig into the old versions of the file. So, rewrite the check to make the intention clear. Signed-of