Re: [Mesa-dev] [PATCH 1/2] nir: Handle =32 case in bitfield_insert lowering.

2016-01-13 Thread Connor Abbott
Both are Reviewed-by: Connor Abbott On Wed, Jan 13, 2016 at 2:25 PM, Matt Turner wrote: > The OpenGL specifications for bitfieldInsert() says: > >The result will be undefined if or is negative, or if >the sum of and is greater than the number of bits >used to store the operand.

[Mesa-dev] [PATCH 1/2] nir: Handle =32 case in bitfield_insert lowering.

2016-01-13 Thread Matt Turner
The OpenGL specifications for bitfieldInsert() says: The result will be undefined if or is negative, or if the sum of and is greater than the number of bits used to store the operand. Therefore passing bits=32, offset=0 is legal and defined in GLSL. But the earlier SM5 bfi opcode is