Re: [Mesa-dev] [PATCH 1/2] nir/dead_cf: Don't crash on unreachable after-loop blocks

2016-09-02 Thread Jason Ekstrand
On Fri, Sep 2, 2016 at 10:39 AM, Kenneth Graunke wrote: > On Thursday, September 1, 2016 7:00:01 PM PDT Connor Abbott wrote: > > On Thu, Sep 1, 2016 at 6:19 PM, Jason Ekstrand > wrote: > > > On Thu, Sep 1, 2016 at 12:41 PM, Connor Abbott > wrote: > > >> > > >> As-is, this change will make us de

Re: [Mesa-dev] [PATCH 1/2] nir/dead_cf: Don't crash on unreachable after-loop blocks

2016-09-02 Thread Kenneth Graunke
On Thursday, September 1, 2016 7:00:01 PM PDT Connor Abbott wrote: > On Thu, Sep 1, 2016 at 6:19 PM, Jason Ekstrand wrote: > > On Thu, Sep 1, 2016 at 12:41 PM, Connor Abbott wrote: > >> > >> As-is, this change will make us delete trivially infinite loops (i.e. > >> loops with no break statement).

Re: [Mesa-dev] [PATCH 1/2] nir/dead_cf: Don't crash on unreachable after-loop blocks

2016-09-01 Thread Connor Abbott
On Thu, Sep 1, 2016 at 6:19 PM, Jason Ekstrand wrote: > On Thu, Sep 1, 2016 at 12:41 PM, Connor Abbott wrote: >> >> As-is, this change will make us delete trivially infinite loops (i.e. >> loops with no break statement). The most likely scenario where we get >> one of those (besides for silly Pig

Re: [Mesa-dev] [PATCH 1/2] nir/dead_cf: Don't crash on unreachable after-loop blocks

2016-09-01 Thread Matt Turner
On Thu, Sep 1, 2016 at 3:19 PM, Jason Ekstrand wrote: > On Thu, Sep 1, 2016 at 12:41 PM, Connor Abbott wrote: >> >> As-is, this change will make us delete trivially infinite loops (i.e. >> loops with no break statement). The most likely scenario where we get >> one of those (besides for silly Pig

Re: [Mesa-dev] [PATCH 1/2] nir/dead_cf: Don't crash on unreachable after-loop blocks

2016-09-01 Thread Jason Ekstrand
On Thu, Sep 1, 2016 at 12:41 PM, Connor Abbott wrote: > As-is, this change will make us delete trivially infinite loops (i.e. > loops with no break statement). The most likely scenario where we get > one of those (besides for silly Piglit tests) is a developer with an > accidental bug in their sh

Re: [Mesa-dev] [PATCH 1/2] nir/dead_cf: Don't crash on unreachable after-loop blocks

2016-09-01 Thread Connor Abbott
As-is, this change will make us delete trivially infinite loops (i.e. loops with no break statement). The most likely scenario where we get one of those (besides for silly Piglit tests) is a developer with an accidental bug in their shader. In that case, it seems kinda mean to then delete the entir

[Mesa-dev] [PATCH 1/2] nir/dead_cf: Don't crash on unreachable after-loop blocks

2016-09-01 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- src/compiler/nir/nir_opt_dead_cf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/compiler/nir/nir_opt_dead_cf.c b/src/compiler/nir/nir_opt_dead_cf.c index 3551124..1490e68 100644 --- a/src/compiler/nir/nir_opt_dead_cf.c +++ b/src/comp