Re: [Mesa-dev] [PATCH 1/2] meta: Add a state flag for the GL_DITHER

2014-07-10 Thread Pohjolainen, Topi
On Mon, Jul 07, 2014 at 12:27:29PM +0100, Neil Roberts wrote: > "Pohjolainen, Topi" writes: > > > All the other state flags considered in _mesa_meta_begin() are > > explicitly set as disabled. And having noticed that you > > unconditionally disable dithering also in cleartexsubimage_using_fbo() >

Re: [Mesa-dev] [PATCH 1/2] meta: Add a state flag for the GL_DITHER

2014-07-07 Thread Neil Roberts
"Pohjolainen, Topi" writes: > All the other state flags considered in _mesa_meta_begin() are > explicitly set as disabled. And having noticed that you > unconditionally disable dithering also in cleartexsubimage_using_fbo() > I'm wondering if I'm missing something. My understanding is that _mesa

Re: [Mesa-dev] [PATCH 1/2] meta: Add a state flag for the GL_DITHER

2014-07-07 Thread Pohjolainen, Topi
On Fri, Jul 04, 2014 at 05:26:43PM +0100, Neil Roberts wrote: > The Meta implementation of glClearTexSubImage is going to want to ensure that > dithering is disabled so that it can get a consistent color across the whole > texture when clearing. This adds a state flag to easily save it and set it t

[Mesa-dev] [PATCH 1/2] meta: Add a state flag for the GL_DITHER

2014-07-04 Thread Neil Roberts
The Meta implementation of glClearTexSubImage is going to want to ensure that dithering is disabled so that it can get a consistent color across the whole texture when clearing. This adds a state flag to easily save it and set it to the default value when performing meta operations. --- src/mesa/d