Re: [Mesa-dev] [PATCH 1/2] meta: Actually initialize ImmutableLevels to 1.

2017-07-14 Thread Ian Romanick
With or without Chris's suggestion on patch 2 (which I like), this series is Reviewed-by: Ian Romancik On 07/13/2017 09:38 PM, Kenneth Graunke wrote: > Otherwise, ImmutableLevels is 0, which is an illegal value. Later, > _mesa_meta_setup_sampler will use _mesa_texture_parameteriv to set > >

[Mesa-dev] [PATCH 1/2] meta: Actually initialize ImmutableLevels to 1.

2017-07-13 Thread Kenneth Graunke
Otherwise, ImmutableLevels is 0, which is an illegal value. Later, _mesa_meta_setup_sampler will use _mesa_texture_parameteriv to set texObj->MaxLevel = CLAMP(params[0], texObj->BaseLevel, texObj->ImmutableLevels - 1); which turns into a completely bogus CLAMP(valu