Re: [Mesa-dev] [PATCH 1/2] mesa/compute: move compute checks around for tests.

2016-08-05 Thread Antía Puentes
Hi! I have taken a look to the GL44-CTS.compute_shader.api-indirect test and I agree with Piñeiro that this test is not correct. A call to glUseProgram to set the active program is missing in the test. The test passes invalid values as parameters to glDispatchComputeIndirect like, glDispa

Re: [Mesa-dev] [PATCH 1/2] mesa/compute: move compute checks around for tests.

2016-05-05 Thread Alejandro Piñeiro
So as far as I understand, on that test there is no active program and indirect length is wrong, and fails because it was expecting the second error. Is that right? Unless Im wrong, when the OpenGL spec specifies the Error cases, it doesn't specify any kind of priority (which error should be raise

[Mesa-dev] [PATCH 1/2] mesa/compute: move compute checks around for tests.

2016-05-04 Thread Dave Airlie
From: Dave Airlie This fixes GL43-CTS.compute_shader.api-indirect which tests the length/4 before anything else. Signed-off-by: Dave Airlie --- src/mesa/main/api_validate.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/ap