Re: [Mesa-dev] [PATCH 1/2] intel: blorp: fix potential NULL pointer dereferences

2017-10-09 Thread Jason Ekstrand
This patch is technically correct (the best kind of correct!) but I'm not sure I like it. width/height and x/y will always come in pairs. This makes the code messier just to get rid of a coverity warning that can easily be verified to never be an issue (by just looking at all 3 callers). --Jason

Re: [Mesa-dev] [PATCH 1/2] intel: blorp: fix potential NULL pointer dereferences

2017-10-09 Thread Antia Puentes
Reviewed-by: Antia Puentes On 09/10/17 16:37, Lionel Landwerlin wrote: CID: 1418616, 1418607 Signed-off-by: Lionel Landwerlin --- src/intel/blorp/blorp_blit.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blor

[Mesa-dev] [PATCH 1/2] intel: blorp: fix potential NULL pointer dereferences

2017-10-09 Thread Lionel Landwerlin
CID: 1418616, 1418607 Signed-off-by: Lionel Landwerlin --- src/intel/blorp/blorp_blit.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/src/intel/blorp/blorp_blit.c b/src/intel/blorp/blorp_blit.c index 11c2116a758..84e46d7d31b 100644 --- a/src/intel/blorp/blo