Re: [Mesa-dev] [PATCH 1/2] intel/fs: Alloc pull constants off mem_ctx

2017-11-03 Thread Andres Gomez
On Wed, 2017-11-01 at 20:58 +0200, Tapani Pälli wrote: > > On 11/01/2017 06:33 PM, Jason Ekstrand wrote: > > Do either of you mind if I cc the first one to stable? It does fix a > > potential memory leak in the case where compilation fails. > > IMO CC stable would be fine for that one. Jason,

Re: [Mesa-dev] [PATCH 1/2] intel/fs: Alloc pull constants off mem_ctx

2017-11-01 Thread Tapani Pälli
On 11/01/2017 06:33 PM, Jason Ekstrand wrote: Do either of you mind if I cc the first one to stable?  It does fix a potential memory leak in the case where compilation fails. IMO CC stable would be fine for that one. On Wed, Nov 1, 2017 at 9:26 AM, Tapani Pälli

Re: [Mesa-dev] [PATCH 1/2] intel/fs: Alloc pull constants off mem_ctx

2017-11-01 Thread Jason Ekstrand
Do either of you mind if I cc the first one to stable? It does fix a potential memory leak in the case where compilation fails. On Wed, Nov 1, 2017 at 9:26 AM, Tapani Pälli wrote: > series > Reviewed-by: Tapani Pälli > > > On 11/01/2017 06:00 PM, Jason Ekstrand wrote: > >> It doesn't actually

Re: [Mesa-dev] [PATCH 1/2] intel/fs: Alloc pull constants off mem_ctx

2017-11-01 Thread Tapani Pälli
series Reviewed-by: Tapani Pälli On 11/01/2017 06:00 PM, Jason Ekstrand wrote: It doesn't actually matter since the only user of push constants, i965, ralloc_steals it back to NULL but it's more consistent and probably fixes memory leaks in some error cases. --- src/intel/compiler/brw_fs.cpp

Re: [Mesa-dev] [PATCH 1/2] intel/fs: Alloc pull constants off mem_ctx

2017-11-01 Thread Lionel Landwerlin
Both patches are : Reviewed-by: Lionel Landwerlin On 01/11/17 16:00, Jason Ekstrand wrote: It doesn't actually matter since the only user of push constants, i965, ralloc_steals it back to NULL but it's more consistent and probably fixes memory leaks in some error cases. --- src/intel/compile

[Mesa-dev] [PATCH 1/2] intel/fs: Alloc pull constants off mem_ctx

2017-11-01 Thread Jason Ekstrand
It doesn't actually matter since the only user of push constants, i965, ralloc_steals it back to NULL but it's more consistent and probably fixes memory leaks in some error cases. --- src/intel/compiler/brw_fs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/compil