Re: [Mesa-dev] [PATCH 1/2] i965: Remove hand-rolled memcpy implementation.

2015-02-23 Thread Ian Romanick
On 02/22/2015 08:40 PM, Matt Turner wrote: > --- > I can't believe this is beneficial, especially since it came from the > i915tex import. My recollection is that memcpy does some weird optimizations (copying from the end first) assuming the memory is mapped in a certain way. We don't necessarily

Re: [Mesa-dev] [PATCH 1/2] i965: Remove hand-rolled memcpy implementation.

2015-02-23 Thread Kenneth Graunke
On Sunday, February 22, 2015 08:40:17 PM Matt Turner wrote: > --- > I can't believe this is beneficial, especially since it came from the > i915tex import. > > src/mesa/drivers/dri/i965/brw_context.h | 27 > --- > src/mesa/drivers/dri/i965/intel_batchbuffer.c | 2 +

Re: [Mesa-dev] [PATCH 1/2] i965: Remove hand-rolled memcpy implementation.

2015-02-22 Thread Eric Anholt
Matt Turner writes: > --- > I can't believe this is beneficial, especially since it came from the > i915tex import. I don't recall any good justification for it, and I don't see any branches I have laying around with evidence recorded for why we have to keep it (which actually kind of surprises

[Mesa-dev] [PATCH 1/2] i965: Remove hand-rolled memcpy implementation.

2015-02-22 Thread Matt Turner
--- I can't believe this is beneficial, especially since it came from the i915tex import. src/mesa/drivers/dri/i965/brw_context.h | 27 --- src/mesa/drivers/dri/i965/intel_batchbuffer.c | 2 +- 2 files changed, 1 insertion(+), 28 deletions(-) diff --git a/src/mesa/